Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: build/android/BUILD.gn

Issue 1829683002: Revert of 🌈 Android: Run lint using a cache in the output directory (fix-up) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/android/android_lint_cache.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/rules.gni") 5 import("//build/config/android/rules.gni")
6 import("//third_party/ijar/ijar.gni") 6 import("//third_party/ijar/ijar.gni")
7 7
8 sun_tools_jar_path = "$root_gen_dir/sun_tools_jar/tools.jar" 8 sun_tools_jar_path = "$root_gen_dir/sun_tools_jar/tools.jar"
9 9
10 # Create or update the API versions cache if necessary by running a 10 # Create or update the API versions cache if necessary by running a
11 # functionally empty lint task. This prevents racy creation of the 11 # functionally empty lint task. This prevents racy creation of the
12 # cache while linting java targets in android_lint. 12 # cache while linting java targets in android_lint.
13 android_lint("prepare_android_lint_cache") { 13 action("prepare_android_lint_cache") {
14 android_manifest = "//build/android/AndroidManifest.xml" 14 _cache_dir = "${root_out_dir}/android_lint_cache"
15 create_cache = true 15 depfile = "${_cache_dir}/prepare_android_lint_cache.d"
16 _manifest_file = "//build/android/AndroidManifest.xml"
17 _result_file = "${_cache_dir}/result.xml"
18 script = "//build/android/gyp/lint.py"
19
20 inputs = [
21 "${android_sdk_root}/platform-tools/api/api-versions.xml",
22 ]
23 outputs = [
24 depfile,
25 ]
26 args = [
27 "--build-tools-version",
28 android_sdk_build_tools_version,
29 "--cache-dir",
30 rebase_path(_cache_dir, root_build_dir),
31 "--depfile",
32 rebase_path(depfile, root_build_dir),
33 "--lint-path",
34 "$rebased_android_sdk_root/tools/lint",
35 "--manifest-path",
36 rebase_path(_manifest_file, root_build_dir),
37 "--product-dir",
38 ".",
39 "--result-path",
40 rebase_path(_result_file, root_build_dir),
41 "--silent",
42 "--enable",
43 ]
16 } 44 }
17 45
18 action("find_sun_tools_jar") { 46 action("find_sun_tools_jar") {
19 script = "//build/android/gyp/find_sun_tools_jar.py" 47 script = "//build/android/gyp/find_sun_tools_jar.py"
20 depfile = "$target_gen_dir/$target_name.d" 48 depfile = "$target_gen_dir/$target_name.d"
21 outputs = [ 49 outputs = [
22 depfile, 50 depfile,
23 sun_tools_jar_path, 51 sun_tools_jar_path,
24 ] 52 ]
25 args = [ 53 args = [
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 _target_name = get_path_info(script, "name") + "_wrapper" 159 _target_name = get_path_info(script, "name") + "_wrapper"
132 _wrapper_targets += [ ":$_target_name" ] 160 _wrapper_targets += [ ":$_target_name" ]
133 wrapper_script(_target_name) { 161 wrapper_script(_target_name) {
134 target = script 162 target = script
135 } 163 }
136 } 164 }
137 165
138 group("wrapper_scripts") { 166 group("wrapper_scripts") {
139 deps = _wrapper_targets 167 deps = _wrapper_targets
140 } 168 }
OLDNEW
« no previous file with comments | « no previous file | build/android/android_lint_cache.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698