App Banner: require 'display' to be set to 'standalone' or 'fullscreen'.

App Banner: require 'display' to be set to 'standalone' or 'fullscreen'.

Also checks that 'name' and 'short_name' are not empty strings.

BUG=596729
Committed: https://crrev.com/1239f9a2a15c7ef8e5e116a8b2ca887088ece5a8
Cr-Commit-Position: refs/heads/master@{#387956}

[mlamouri (slow - plz ping), 2016-03-23 10:30:28]

mlamouri@chromium.org changed reviewers:
+ dominickn@chromium.org, jochen@chromium.org

[mlamouri (slow - plz ping), 2016-03-23 10:30:28]

jochen@, PTAL at chrome/browser/DEPS change

dominickn@, PTAL at everything else.

Also, let me know if you want me to split this in two CLs.

[mlamouri (slow - plz ping), 2016-03-23 10:30:34]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-23 10:30:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829643002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829643002/1

[commit-bot: I haz the power, 2016-03-23 10:38:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 10:39:00]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dominickn, 2016-03-23 11:40:54]

https://codereview.chromium.org/1829643002/diff/1/chrome/browser/banners/app_...
File chrome/browser/banners/app_banner_data_fetcher_unittest.cc (right):

https://codereview.chromium.org/1829643002/diff/1/chrome/browser/banners/app_...
chrome/browser/banners/app_banner_data_fetcher_unittest.cc:83:
EXPECT_TRUE(IsManifestValid(manifest));
Nit: Isn't short_name already empty at this point? This should set short_name to
something not empty, EXPECT_TRUE, then blank out name and EXPECT_TRUE right?

[mlamouri (slow - plz ping), 2016-03-23 11:46:10]

PTAL.

https://codereview.chromium.org/1829643002/diff/1/chrome/browser/banners/app_...
File chrome/browser/banners/app_banner_data_fetcher_unittest.cc (right):

https://codereview.chromium.org/1829643002/diff/1/chrome/browser/banners/app_...
chrome/browser/banners/app_banner_data_fetcher_unittest.cc:83:
EXPECT_TRUE(IsManifestValid(manifest));
On 2016/03/23 at 11:40:53, dominickn wrote:
> Nit: Isn't short_name already empty at this point? This should set short_name
to something not empty, EXPECT_TRUE, then blank out name and EXPECT_TRUE right?

Correct. I did some changes before upload that made part of this test less
useful.

[dominickn, 2016-03-23 12:37:02]

lgtm

[jochen (gone - plz use gerrit), 2016-03-24 14:36:21]

lgtm

[pfeldman, 2016-03-28 18:18:59]

On 2016/03/24 14:36:21, jochen - slow wrote:
> lgtm

Do you want to land this? They say I have to rebaseline on top of it.

[mlamouri (slow - plz ping), 2016-03-30 22:45:33]

On 2016/03/28 at 18:18:59, pfeldman wrote:
> On 2016/03/24 14:36:21, jochen - slow wrote:
> > lgtm
> 
> Do you want to land this? They say I have to rebaseline on top of it.

I'm waiting for a product decision. Consider this CL stalled in the mean time.

[mlamouri (slow - plz ping), 2016-04-18 17:30:08]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-04-18 17:30:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominickn@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1829643002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-04-18 17:30:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829643002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829643002/40001

[commit-bot: I haz the power, 2016-04-18 18:15:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-18 18:16:32]

Description was changed from

==========
App Banner: require 'display' to be set to 'standalone' or 'fullscreen'.

Also checks that 'name' and 'short_name' are not empty strings.

BUG=596729
==========

to

==========
App Banner: require 'display' to be set to 'standalone' or 'fullscreen'.

Also checks that 'name' and 'short_name' are not empty strings.

BUG=596729

Committed: https://crrev.com/1239f9a2a15c7ef8e5e116a8b2ca887088ece5a8
Cr-Commit-Position: refs/heads/master@{#387956}
==========

[commit-bot: I haz the power, 2016-04-18 18:16:33]

Patchset 3 (id:??) landed as
https://crrev.com/1239f9a2a15c7ef8e5e116a8b2ca887088ece5a8
Cr-Commit-Position: refs/heads/master@{#387956}