Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: chrome/browser/banners/app_banner_debug_log.cc

Issue 1829643002: App Banner: require 'display' to be set to 'standalone' or 'fullscreen'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/banners/app_banner_debug_log.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_debug_log.cc
diff --git a/chrome/browser/banners/app_banner_debug_log.cc b/chrome/browser/banners/app_banner_debug_log.cc
index bff2cdf87d53a0f936ccfd553030077557456dca..dac19e0351a7961a054f98eb967872259871de1e 100644
--- a/chrome/browser/banners/app_banner_debug_log.cc
+++ b/chrome/browser/banners/app_banner_debug_log.cc
@@ -30,6 +30,8 @@ static const char kUserNavigatedBeforeBannerShownMessage[] =
"the user navigated before the banner could be shown";
static const char kStartURLNotValidMessage[] =
"start URL in manifest is not valid";
+static const char kManifestDisplayStandaloneFullscreenMessage[] =
+ "manifest display property must be set to 'standalone' or 'fullscreen'";
static const char kManifestMissingNameOrShortNameMessage[] =
"one of manifest name or short name must be specified";
static const char kManifestMissingSuitableIconMessage[] =
@@ -94,6 +96,9 @@ void OutputDeveloperNotShownMessage(content::WebContents* web_contents,
case kStartURLNotValid:
pattern = kStartURLNotValidMessage;
break;
+ case kManifestDisplayStandaloneFullscreen:
+ pattern = kManifestDisplayStandaloneFullscreenMessage;
+ break;
case kManifestMissingNameOrShortName:
pattern = kManifestMissingNameOrShortNameMessage;
break;
« no previous file with comments | « chrome/browser/banners/app_banner_debug_log.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698