Skia: Run recipes as swarming tasks

Skia: Run recipes as swarming tasks

Isolate the recipes and use recipes.py to run the recipe. This is what kitchen (and by extension, Swarmbucket) uses to run recipes.

BUG=skia:4763
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299565

[borenet, 2016-03-25 18:37:25]

borenet@google.com changed reviewers:
+ borenet@google.com, rmistry@chromium.org

[rmistry, 2016-03-28 12:52:15]

rmistry@google.com changed reviewers:
+ rmistry@google.com

[rmistry, 2016-03-28 12:52:16]

lgtm

https://codereview.chromium.org/1829423002/diff/1/scripts/slave/recipes/skia/...
File scripts/slave/recipes/skia/swarm_trigger.py (right):

https://codereview.chromium.org/1829423002/diff/1/scripts/slave/recipes/skia/...
scripts/slave/recipes/skia/swarm_trigger.py:90:
extra_isolate_hashes.append('8ba778e47df2a9b46355cf72c58b58fdb1a7f350')
Document where you got this hash from?

[borenet, 2016-03-30 13:18:46]

Description was changed from

==========
Skia: Run recipes as swarming tasks via kitchen

BUG=skia:4763
==========

to

==========
Skia: Run recipes as swarming tasks

Isolate the recipes and use recipes.py to run the recipe. This is what kitchen
(and by extension, Swarmbucket) uses to run recipes.

BUG=skia:4763
==========

[borenet, 2016-03-30 14:00:31]

PTAL at patch set 4, which changes to use recipes.py instead of kitchen. This is
cleaner.  This is a breaking change, and must land alongside
https://codereview.chromium.org/1827413002/

[rmistry, 2016-03-30 14:14:16]

https://codereview.chromium.org/1829423002/diff/60001/scripts/slave/recipes/s...
File scripts/slave/recipes/skia/recipes.isolate (right):

https://codereview.chromium.org/1829423002/diff/60001/scripts/slave/recipes/s...
scripts/slave/recipes/skia/recipes.isolate:5: # TODO(borenet): The file list can
probably be made smaller.
I used to do something similar for the ct isolate file for telemetry's
dependencies. The problem is when there is any change to the location of any
file here or a changed dependency then the whole thing falls apart. The longer
the list the more it is prone to failures.

There should really be a recipes.isolate at the top level (maybe
scripts/slave/recipes/) and it should be maintained by cit with tests to ensure
that it always succeeds.
Something like
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/telemetry_p...

[borenet, 2016-03-30 14:23:46]

https://codereview.chromium.org/1829423002/diff/60001/scripts/slave/recipes/s...
File scripts/slave/recipes/skia/recipes.isolate (right):

https://codereview.chromium.org/1829423002/diff/60001/scripts/slave/recipes/s...
scripts/slave/recipes/skia/recipes.isolate:5: # TODO(borenet): The file list can
probably be made smaller.
On 2016/03/30 14:14:16, rmistry wrote:
> I used to do something similar for the ct isolate file for telemetry's
> dependencies. The problem is when there is any change to the location of any
> file here or a changed dependency then the whole thing falls apart. The longer
> the list the more it is prone to failures.
> 
> There should really be a recipes.isolate at the top level (maybe
> scripts/slave/recipes/) and it should be maintained by cit with tests to
ensure
> that it always succeeds.
> Something like
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/telemetry_p...

There is a recipes.isolate already, but it was missing a couple of things so I
wrote my own:
https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave...

In a subsequent CL I'll change to using the old recipes.isolate, and fix it so
that it includes everything we need.

[rmistry, 2016-03-30 14:24:50]

lgtm

[borenet, 2016-03-30 14:25:40]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2016-03-30 14:25:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829423002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829423002/60001

[commit-bot: I haz the power, 2016-03-30 14:31:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 14:31:57]

Try jobs failed on following builders:
  Build Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[borenet, 2016-03-30 14:35:45]

The CQ bit was checked by borenet@google.com

[borenet, 2016-03-30 14:35:46]

The patchset sent to the CQ was uploaded after l-g-t-m from rmistry@google.com
Link to the patchset: https://codereview.chromium.org/1829423002/#ps80001
(title: "Fix presubmit")

[commit-bot: I haz the power, 2016-03-30 14:35:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829423002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829423002/80001

[commit-bot: I haz the power, 2016-03-30 14:39:34]

Description was changed from

==========
Skia: Run recipes as swarming tasks

Isolate the recipes and use recipes.py to run the recipe. This is what kitchen
(and by extension, Swarmbucket) uses to run recipes.

BUG=skia:4763
==========

to

==========
Skia: Run recipes as swarming tasks

Isolate the recipes and use recipes.py to run the recipe. This is what kitchen
(and by extension, Swarmbucket) uses to run recipes.

BUG=skia:4763

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299565
==========

[commit-bot: I haz the power, 2016-03-30 14:39:35]

Committed patchset #5 (id:80001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299565