scripts/slave/recipes/skia/recipes.isolate - Issue 1829423002: Skia: Run recipes as swarming tasks

Side by Side Diff: scripts/slave/recipes/skia/recipes.isolate

Issue 1829423002: Skia: Run recipes as swarming tasks (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@swarm_fix

Patch Set: Reinstate tmp-dir Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipe_modules/skia_swarming/api.py ('k') | scripts/slave/recipes/skia/swarm_perf.expected/Perf-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Release.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 # TODO(borenet): The file list can probably be made smaller.
	rmistry 2016/03/30 14:14:16 I used to do something similar for the ct isolate I used to do something similar for the ct isolate file for telemetry's dependencies. The problem is when there is any change to the location of any file here or a changed dependency then the whole thing falls apart. The longer the list the more it is prone to failures. There should really be a recipes.isolate at the top level (maybe scripts/slave/recipes/) and it should be maintained by cit with tests to ensure that it always succeeds. Something like https://code.google.com/p/chromium/codesearch#chromium/src/chrome/telemetry_p... borenet 2016/03/30 14:23:45 There is a recipes.isolate already, but it was mis Show quoted text On 2016/03/30 14:14:16, rmistry wrote: > I used to do something similar for the ct isolate file for telemetry's > dependencies. The problem is when there is any change to the location of any > file here or a changed dependency then the whole thing falls apart. The longer > the list the more it is prone to failures. > > There should really be a recipes.isolate at the top level (maybe > scripts/slave/recipes/) and it should be maintained by cit with tests to ensure > that it always succeeds. > Something like > https://code.google.com/p/chromium/codesearch#chromium/src/chrome/telemetry_p... There is a recipes.isolate already, but it was missing a couple of things so I wrote my own: https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave... In a subsequent CL I'll change to using the old recipes.isolate, and fix it so that it includes everything we need.
	6 {

	7 'variables': {

	8 'files': [

	9 '../../../../../depot_tools/',

	10 '../../../../site_config/',

	11 '../../../../environment.cfg.py',

	12 '../../../../infra/config/recipes.cfg',

	13 '../../../../third_party/mock-1.0.1/',

	14 '../../../../scripts/common/',

	15 '../../../../scripts/tools/runit.py',

	16 '../../../../scripts/slave/__init__.py',

	17 '../../../../scripts/slave/annotation_utils.py',

	18 '../../../../scripts/slave/annotated_run.py',

	19 '../../../../scripts/slave/bootstrap.py',

	20 '../../../../scripts/slave/bot_update.py',

	21 '../../../../scripts/slave/build_directory.py',

	22 '../../../../scripts/slave/cleanup_temp.py',

	23 '../../../../scripts/slave/compile.py',

	24 '../../../../scripts/slave/crash_utils.py',

	25 '../../../../scripts/slave/gsutil',

	26 '../../../../scripts/slave/gsutil.bat',

	27 '../../../../scripts/slave/gtest/',

	28 '../../../../scripts/slave/gtest_slave_utils.py',

	29 '../../../../scripts/slave/performance_log_processor.py',

	30 '../../../../scripts/slave/recipes.py',

	31 '../../../../scripts/slave/recipes/',

	32 '../../../../scripts/slave/recipe_modules/',

	33 '../../../../scripts/slave/results_dashboard.py',

	34 '../../../../scripts/slave/runtest.py',

	35 '../../../../scripts/slave/runisolatedtest.py',

	36 '../../../../scripts/slave/skia/',

	37 '../../../../scripts/slave/slave_utils.py',

	38 '../../../../scripts/slave/telemetry_utils.py',

	39 '../../../../scripts/slave/xvfb.py',

	40 ],

	41 'command': [

	42 'python', '../../../build/scripts/slave/recipes.py', 'run',

	43 ],

	44 },

	45 }

OLD	NEW