Clean up font loading

Clean up font loading

* FontLoader is mostly a wrapper to start font loads asynchronously, which appears to be a historical artifact that was only necessary for WebKit/mac/. Merge the remaining bits into RemoteFontFaceSource.
* Use FetchRequest::DeferOption to prevent font loads from starting immediately, rather than an override of Resource::load.
* Change the font load timeout timers to start when the font is first needed, not when it is requested. This ensures that the timers do not begin when a font is preloaded, which seems to be more compliant with the spec: https://tabatkins.github.io/specs/css-font-display/#timeline

BUG=

Committed: https://crrev.com/89992c023651c3d75494552a2bcff095f6d4d79f
Cr-Commit-Position: refs/heads/master@{#387061}

[Nate Chapin, 2016-03-30 21:41:02]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 21:41:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829403002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829403002/60001

[commit-bot: I haz the power, 2016-03-30 23:06:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 23:06:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nate Chapin, 2016-03-31 23:00:07]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 23:00:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829403002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829403002/80001

[commit-bot: I haz the power, 2016-04-01 06:34:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 06:34:02]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Nate Chapin, 2016-04-04 23:49:00]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 23:49:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829403002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829403002/100001

[commit-bot: I haz the power, 2016-04-05 00:04:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 00:04:06]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nate Chapin, 2016-04-07 22:08:04]

Description was changed from

==========
Get rid of FontLoader


+font simplification


Cleanup requestResource()

BUG=
==========

to

==========
Clean up font loading

* FontLoader is mostly a wrapper to start font loads asynchronously, which
appears to be a historical artifact that was only necessary for WebKit/mac/.
Merge the remaining bits into RemoteFontFaceSource.
* Use FetchRequest::DeferOption to prevent font loads from starting immediately,
rather than an override of Resource::load.
* Change the font load timeout timers to start when the font is first needed,
not when it is requested. This ensures that the timers do not begin when a font
is preloaded, which seems to be more compliant with the spec:
https://tabatkins.github.io/specs/css-font-display/#timeline

BUG=
==========

[Nate Chapin, 2016-04-07 23:46:15]

japhet@chromium.org changed reviewers:
+ ksakamoto@chromium.org, toyoshim@chromium.org

[Nate Chapin, 2016-04-07 23:46:17]

ksakamoto, toyoshim: you both seem to be active in the font loading logic. Do
you have opinions on this CL?

https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/webfont/css-change-in-swap-period.html
(right):

https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/webfont/css-change-in-swap-period.html:21:
window.onload = setTimeout(runTest, 0);
Without the setTimeout(,0), the font load would start synchronously and block
test completion for the full delay=8000, leading to timeouts.

The change that lead to the font load blocking test completion isn't a concern
in the real world, because the bit that the test harness is checking
(WebLocalFrameImpl::isResourceLoadInProgress) is only used for determining test
completion. It doesn't block things like the parent frame's load event or
didStopLoading() callbacks.

https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/FontLoader.cpp (left):

https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/FontLoader.cpp:75:
m_beginLoadingTimer.startOneShot(0, BLINK_FROM_HERE);
Instead of starting the font load on a timer, just do it immediately. This
appears to have been added to defend against a type of reentrancy that was a
problem for WebKit mac apps, but was never a problem for chromium.

https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/FontLoader.cpp:105:
m_fontSelector->fontFaceInvalidated();
RemoteFontFaceSource now calls this directly.

https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/FontLoader.cpp:113:
m_fontSelector->document()->addConsoleMessage(ConsoleMessage::create(OtherMessageSource,
WarningMessageLevel, "Failed to decode downloaded font: " +
fontResource->url().elidedString()));
Inlined in RemoteFontFaceSource::fontLoaded.

https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp (right):

https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp:185:
m_font->startLoadLimitTimersIfNeeded();
https://tabatkins.github.io/specs/css-font-display/#timeline says: "At the
moment the user agent first attempts to use a given downloaded font face on a
page, the font face’s font download timer is started."

Before this change, we always start the download timer when the we begin the
resource load, *even if it's a preload*. I chatted with tabatkins, and we agree
that's wrong, so with this change we start the timers when the load would have
begun if we hadn't preloaded it.

This has the benefit of removing the last override Resource::load :)

https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/fetch/Resource.cpp (right):

https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/fetch/Resource.cpp:260: ASSERT(stillNeedsLoad());
The changes to ImageResource were to facilitate this ASSERT.

https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/fetch/Resource.cpp:464: m_status = NotStarted;
Also to enable the ASSERT in Resource::load

[hiroshige, 2016-04-08 01:02:03]

hiroshige@chromium.org changed reviewers:
+ hiroshige@chromium.org

[hiroshige, 2016-04-08 01:02:04]

https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/webfont/css-change-in-swap-period.html
(right):

https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/webfont/css-change-in-swap-period.html:21:
window.onload = setTimeout(runTest, 0);
On 2016/04/07 23:46:16, Nate Chapin wrote:
> Without the setTimeout(,0), the font load would start synchronously and block
> test completion for the full delay=8000, leading to timeouts.
> 
> The change that lead to the font load blocking test completion isn't a concern
> in the real world, because the bit that the test harness is checking
> (WebLocalFrameImpl::isResourceLoadInProgress) is only used for determining
test
> completion. It doesn't block things like the parent frame's load event or
> didStopLoading() callbacks.

Shouldn't this be |window.onload = function() { setTimeout(runTest, 0); };| ?

https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/fetch/ImageResource.h (right):

https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/fetch/ImageResource.h:133: ImageResource(const
ResourceRequest&, blink::Image*, const ResourceLoaderOptions&);
We can remove this decralation.

[Kunihiko Sakamoto, 2016-04-08 02:37:16]

Nice! This would make webfont a bit faster :)
LGTM w/ hiroshige's comments addressed.

https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp (right):

https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp:185:
m_font->startLoadLimitTimersIfNeeded();
On 2016/04/07 23:46:16, Nate Chapin wrote:
> https://tabatkins.github.io/specs/css-font-display/#timeline says: "At the
> moment the user agent first attempts to use a given downloaded font face on a
> page, the font face’s font download timer is started."
> 
> Before this change, we always start the download timer when the we begin the
> resource load, *even if it's a preload*. I chatted with tabatkins, and we
agree
> that's wrong, so with this change we start the timers when the load would have
> begun if we hadn't preloaded it.
> 
> This has the benefit of removing the last override Resource::load :)

Agreed, thanks for doing this!

[Yoav Weiss, 2016-04-08 07:10:51]

On 2016/04/08 02:37:16, Kunihiko Sakamoto wrote:
> Nice! This would make webfont a bit faster :)
> LGTM w/ hiroshige's comments addressed.
> 
>
https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp (right):
> 
>
https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
> third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp:185:
> m_font->startLoadLimitTimersIfNeeded();
> On 2016/04/07 23:46:16, Nate Chapin wrote:
> > https://tabatkins.github.io/specs/css-font-display/#timeline says: "At the
> > moment the user agent first attempts to use a given downloaded font face on
a
> > page, the font face’s font download timer is started."
> > 
> > Before this change, we always start the download timer when the we begin the
> > resource load, *even if it's a preload*. I chatted with tabatkins, and we
> agree
> > that's wrong, so with this change we start the timers when the load would
have
> > begun if we hadn't preloaded it.
> > 
> > This has the benefit of removing the last override Resource::load :)
> 
> Agreed, thanks for doing this!

Not strictly related to this change, but IMO it'd be nice to give some thought
to bringing in more loading logic from css/ and dom/ into loader/

[Takashi Toyoshima, 2016-04-11 11:51:54]

lgtm.

https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/fetch/FontResource.cpp (right):

https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/fetch/FontResource.cpp:148:
ASSERT(m_loadLimitState == UnderLimit);
On reviewing this change, I noticed this assertion fires on Ctrl+R reload, but
not introduced by this change, but exists in trunk.
I'll fix once this change is landed.

https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp (right):

https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp:667: if
(existingResource->isImage() && (FetchRequest::DeferredByClient ==
fetchRequest.defer() || !context().allowImage(m_imagesEnabled,
existingResource->url())))
So, we will return USE for font resources even if it has DeferredByClient
option, right?

[Nate Chapin, 2016-04-11 18:47:32]

https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/webfont/css-change-in-swap-period.html
(right):

https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/webfont/css-change-in-swap-period.html:21:
window.onload = setTimeout(runTest, 0);
On 2016/04/08 01:02:04, hiroshige wrote:
> On 2016/04/07 23:46:16, Nate Chapin wrote:
> > Without the setTimeout(,0), the font load would start synchronously and
block
> > test completion for the full delay=8000, leading to timeouts.
> > 
> > The change that lead to the font load blocking test completion isn't a
concern
> > in the real world, because the bit that the test harness is checking
> > (WebLocalFrameImpl::isResourceLoadInProgress) is only used for determining
> test
> > completion. It doesn't block things like the parent frame's load event or
> > didStopLoading() callbacks.
> 
> Shouldn't this be |window.onload = function() { setTimeout(runTest, 0); };| ?

Wow, I'm bad at Javascript. Done.

https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/fetch/ImageResource.h (right):

https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/fetch/ImageResource.h:133: ImageResource(const
ResourceRequest&, blink::Image*, const ResourceLoaderOptions&);
On 2016/04/08 01:02:04, hiroshige wrote:
> We can remove this decralation.

Done.

https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp (right):

https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp:667: if
(existingResource->isImage() && (FetchRequest::DeferredByClient ==
fetchRequest.defer() || !context().allowImage(m_imagesEnabled,
existingResource->url())))
On 2016/04/11 11:51:54, toyoshim wrote:
> So, we will return USE for font resources even if it has DeferredByClient
> option, right?

Correct. This logic is a messy special-case for Images that I really ought to
clean up :)

[Nate Chapin, 2016-04-11 18:49:54]

On 2016/04/08 07:10:51, Yoav Weiss wrote:
> On 2016/04/08 02:37:16, Kunihiko Sakamoto wrote:
> > Nice! This would make webfont a bit faster :)
> > LGTM w/ hiroshige's comments addressed.
> > 
> >
>
https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
> > File third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp (right):
> > 
> >
>
https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
> > third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp:185:
> > m_font->startLoadLimitTimersIfNeeded();
> > On 2016/04/07 23:46:16, Nate Chapin wrote:
> > > https://tabatkins.github.io/specs/css-font-display/#timeline says: "At the
> > > moment the user agent first attempts to use a given downloaded font face
on
> a
> > > page, the font face’s font download timer is started."
> > > 
> > > Before this change, we always start the download timer when the we begin
the
> > > resource load, *even if it's a preload*. I chatted with tabatkins, and we
> > agree
> > > that's wrong, so with this change we start the timers when the load would
> have
> > > begun if we hadn't preloaded it.
> > > 
> > > This has the benefit of removing the last override Resource::load :)
> > 
> > Agreed, thanks for doing this!
> 
> Not strictly related to this change, but IMO it'd be nice to give some thought
> to bringing in more loading logic from css/ and dom/ into loader/

The current split is inconsistent (e.g., ImageLoader is in loader/, but
ScriptLoader is in dom/). I'm still debating whether I'd prefer to bring more
things into loader/, or whether loader/ is not a useful abstraction and its
contents should be split out into the same directories as its callers (e.g.,
TextTrackLoader into html/, ImageLoader into dom/, FrameLoader into frame/,
etc.). Opinions welcome :)

[Nate Chapin, 2016-04-12 23:51:17]

On 2016/04/11 18:47:32, Nate Chapin wrote:
>
https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Lay...
> File
>
third_party/WebKit/LayoutTests/http/tests/webfont/css-change-in-swap-period.html
> (right):
> 
>
https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Lay...
>
third_party/WebKit/LayoutTests/http/tests/webfont/css-change-in-swap-period.html:21:
> window.onload = setTimeout(runTest, 0);
> On 2016/04/08 01:02:04, hiroshige wrote:
> > On 2016/04/07 23:46:16, Nate Chapin wrote:
> > > Without the setTimeout(,0), the font load would start synchronously and
> block
> > > test completion for the full delay=8000, leading to timeouts.
> > > 
> > > The change that lead to the font load blocking test completion isn't a
> concern
> > > in the real world, because the bit that the test harness is checking
> > > (WebLocalFrameImpl::isResourceLoadInProgress) is only used for determining
> > test
> > > completion. It doesn't block things like the parent frame's load event or
> > > didStopLoading() callbacks.
> > 
> > Shouldn't this be |window.onload = function() { setTimeout(runTest, 0); };|
?
> 
> Wow, I'm bad at Javascript. Done.
> 
>
https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/core/fetch/ImageResource.h (right):
> 
>
https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
> third_party/WebKit/Source/core/fetch/ImageResource.h:133: ImageResource(const
> ResourceRequest&, blink::Image*, const ResourceLoaderOptions&);
> On 2016/04/08 01:02:04, hiroshige wrote:
> > We can remove this decralation.
> 
> Done.
> 
>
https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp (right):
> 
>
https://codereview.chromium.org/1829403002/diff/160001/third_party/WebKit/Sou...
> third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp:667: if
> (existingResource->isImage() && (FetchRequest::DeferredByClient ==
> fetchRequest.defer() || !context().allowImage(m_imagesEnabled,
> existingResource->url())))
> On 2016/04/11 11:51:54, toyoshim wrote:
> > So, we will return USE for font resources even if it has DeferredByClient
> > option, right?
> 
> Correct. This logic is a messy special-case for Images that I really ought to
> clean up :)

hiroshige@, is this CL good to go?

[hiroshige, 2016-04-13 09:48:23]

lgtm with a comment.

https://codereview.chromium.org/1829403002/diff/170001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/webfont/css-change-in-swap-period.html
(right):

https://codereview.chromium.org/1829403002/diff/170001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/webfont/css-change-in-swap-period.html:23:
}
Add a semicolon at the end of this line.
i.e. s/}/};/

https://google.github.io/styleguide/javascriptguide.xml?showone=Semicolons#Se...

[Nate Chapin, 2016-04-13 17:00:45]

The CQ bit was checked by japhet@chromium.org

[Nate Chapin, 2016-04-13 17:00:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
toyoshim@chromium.org, ksakamoto@chromium.org, hiroshige@chromium.org
Link to the patchset: https://codereview.chromium.org/1829403002/#ps190001
(title: "Rebase, +semicolon")

[commit-bot: I haz the power, 2016-04-13 17:01:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829403002/190001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829403002/190001

[commit-bot: I haz the power, 2016-04-13 17:04:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 17:04:09]

Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Nate Chapin, 2016-04-13 17:47:24]

https://codereview.chromium.org/1829403002/diff/170001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/webfont/css-change-in-swap-period.html
(right):

https://codereview.chromium.org/1829403002/diff/170001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/webfont/css-change-in-swap-period.html:23:
}
On 2016/04/13 09:48:23, hiroshige wrote:
> Add a semicolon at the end of this line.
> i.e. s/}/};/
> 
>
https://google.github.io/styleguide/javascriptguide.xml?showone=Semicolons#Se...

Done.

[Nate Chapin, 2016-04-13 17:47:33]

The CQ bit was checked by japhet@chromium.org

[Nate Chapin, 2016-04-13 17:47:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
hiroshige@chromium.org, toyoshim@chromium.org, ksakamoto@chromium.org
Link to the patchset: https://codereview.chromium.org/1829403002/#ps210001
(title: "Another rebase!")

[commit-bot: I haz the power, 2016-04-13 17:47:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829403002/210001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829403002/210001

[commit-bot: I haz the power, 2016-04-13 19:10:50]

Description was changed from

==========
Clean up font loading

* FontLoader is mostly a wrapper to start font loads asynchronously, which
appears to be a historical artifact that was only necessary for WebKit/mac/.
Merge the remaining bits into RemoteFontFaceSource.
* Use FetchRequest::DeferOption to prevent font loads from starting immediately,
rather than an override of Resource::load.
* Change the font load timeout timers to start when the font is first needed,
not when it is requested. This ensures that the timers do not begin when a font
is preloaded, which seems to be more compliant with the spec:
https://tabatkins.github.io/specs/css-font-display/#timeline

BUG=
==========

to

==========
Clean up font loading

* FontLoader is mostly a wrapper to start font loads asynchronously, which
appears to be a historical artifact that was only necessary for WebKit/mac/.
Merge the remaining bits into RemoteFontFaceSource.
* Use FetchRequest::DeferOption to prevent font loads from starting immediately,
rather than an override of Resource::load.
* Change the font load timeout timers to start when the font is first needed,
not when it is requested. This ensures that the timers do not begin when a font
is preloaded, which seems to be more compliant with the spec:
https://tabatkins.github.io/specs/css-font-display/#timeline

BUG=
==========

[commit-bot: I haz the power, 2016-04-13 19:10:52]

Committed patchset #12 (id:210001)

[commit-bot: I haz the power, 2016-04-13 19:13:07]

Description was changed from

==========
Clean up font loading

* FontLoader is mostly a wrapper to start font loads asynchronously, which
appears to be a historical artifact that was only necessary for WebKit/mac/.
Merge the remaining bits into RemoteFontFaceSource.
* Use FetchRequest::DeferOption to prevent font loads from starting immediately,
rather than an override of Resource::load.
* Change the font load timeout timers to start when the font is first needed,
not when it is requested. This ensures that the timers do not begin when a font
is preloaded, which seems to be more compliant with the spec:
https://tabatkins.github.io/specs/css-font-display/#timeline

BUG=
==========

to

==========
Clean up font loading

* FontLoader is mostly a wrapper to start font loads asynchronously, which
appears to be a historical artifact that was only necessary for WebKit/mac/.
Merge the remaining bits into RemoteFontFaceSource.
* Use FetchRequest::DeferOption to prevent font loads from starting immediately,
rather than an override of Resource::load.
* Change the font load timeout timers to start when the font is first needed,
not when it is requested. This ensures that the timers do not begin when a font
is preloaded, which seems to be more compliant with the spec:
https://tabatkins.github.io/specs/css-font-display/#timeline

BUG=

Committed: https://crrev.com/89992c023651c3d75494552a2bcff095f6d4d79f
Cr-Commit-Position: refs/heads/master@{#387061}
==========

[commit-bot: I haz the power, 2016-04-13 19:13:09]

Patchset 12 (id:??) landed as
https://crrev.com/89992c023651c3d75494552a2bcff095f6d4d79f
Cr-Commit-Position: refs/heads/master@{#387061}