third_party/WebKit/Source/core/css/CSSFontSelector.cpp - Issue 1829403002: Clean up font loading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSFontSelector.cpp

Issue 1829403002: Clean up font loading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Resource_status

Patch Set: Another rebase! Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSFontSelector.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSFontSelector.cpp b/third_party/WebKit/Source/core/css/CSSFontSelector.cpp

index 2ef70ed3ba15aefba3ad086b71f9e07ea724979a..5f3c79de4d0b22c83f6576eb4f9953ce26828f2b 100644

--- a/third_party/WebKit/Source/core/css/CSSFontSelector.cpp

+++ b/third_party/WebKit/Source/core/css/CSSFontSelector.cpp

@@ -44,7 +44,6 @@ namespace blink {

CSSFontSelector::CSSFontSelector(Document* document)

: m_document(document)

- , m_fontLoader(FontLoader::create(this, document))

, m_genericFontFamilySettings(document->frame()->settings()->genericFontFamilySettings())

{

// FIXME: An old comment used to say there was no need to hold a reference to m_document

@@ -164,7 +163,6 @@ DEFINE_TRACE(CSSFontSelector)

visitor->trace(m_document);

visitor->trace(m_fontFaceCache);

visitor->trace(m_clients);

- visitor->trace(m_fontLoader);

FontSelector::trace(visitor);

}