src/utils/SkLua.cpp - Issue 1829303002: move setshader to sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils/SkLua.cpp

Issue 1829303002: move setshader to sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: addressing comments from #8 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/utils/SkLua.cpp

diff --git a/src/utils/SkLua.cpp b/src/utils/SkLua.cpp

index c25bbf4409ffe412cadc4a1f20a0f9679bac975e..01bf507f170052504bb40206434bb64339c43e33 100644

--- a/src/utils/SkLua.cpp

+++ b/src/utils/SkLua.cpp

@@ -1146,7 +1146,7 @@ static int lpaint_getShader(lua_State* L) {

static int lpaint_setShader(lua_State* L) {

SkPaint* paint = get_obj<SkPaint>(L, 1);

- paint->setShader(get_ref<SkShader>(L, 2));

+ paint->setShader(sk_ref_sp(get_ref<SkShader>(L, 2)));

return 0;

}

« no previous file with comments | « src/pdf/SkPDFShader.cpp ('k') | tests/ImageFilterTest.cpp » ('j') | no next file with comments »