gm/dcshader.cpp - Issue 1829303002: move setshader to sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/dcshader.cpp

Issue 1829303002: move setshader to sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: addressing comments from #8 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/dcshader.cpp

diff --git a/gm/dcshader.cpp b/gm/dcshader.cpp

index 4dedf74093e0bb8c04af2dd2c45457b8b7ce1f8e..ed2b058e51b09c0d33fe5fc2d9d7e2ff9108a166 100644

--- a/gm/dcshader.cpp

+++ b/gm/dcshader.cpp

@@ -257,7 +257,7 @@ protected:

for (int i = 0; i < fPrims.count(); ++i) {

for (int j = 0; j < devMats.count(); ++j) {

for (int k = 0; k < viewMats.count(); ++k) {

- paint.setShader(new DCShader(devMats[j]))->unref();

+ paint.setShader(sk_make_sp<DCShader>(devMats[j]));

paint.setAntiAlias(SkToBool(aa));

canvas->save();

canvas->concat(viewMats[k]);

« no previous file with comments | « bench/ShaderMaskBench.cpp ('k') | gm/discard.cpp » ('j') | no next file with comments »