Issue 18292002: Rename chromium-android port to android

Issue 18292002: Rename chromium-android port to android (Closed)

Created:
7 years, 5 months ago by Steve Block

Modified:
7 years, 5 months ago

Reviewers:
Dirk Pranke, ojan

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Rename chromium-android port to android Also renames the ChromiumAndroidPort class to AndroidPort. A later change will update the relevant LayoutTest platform directory accordingly. BUG=231188 R=ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153597

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added a TODO to remove '--platform chromium' #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -1341 lines)			Patch
M	Tools/Scripts/webkitpy/common/config/ports.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download
A +	Tools/Scripts/webkitpy/layout_tests/port/android.py	View	1	4 chunks	+5 lines, -5 lines	0 comments	Download
A +	Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py	View		6 chunks	+23 lines, -23 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/port/builders.py	View		1 chunk	+1 line, -1 line	0 comments	Download
D	Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py	View	1	1 chunk	+0 lines, -1070 lines	0 comments	Download
D	Tools/Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py	View		1 chunk	+0 lines, -220 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/port/factory.py	View	1	2 chunks	+4 lines, -14 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Steve Block

Note that this depends on https://codereview.chromium.org/18291002/

7 years, 5 months ago (2013-06-30 09:16:28 UTC) #1

ojan

lgtm https://codereview.chromium.org/18292002/diff/1/Tools/Scripts/webkitpy/layout_tests/port/factory.py File Tools/Scripts/webkitpy/layout_tests/port/factory.py (right): https://codereview.chromium.org/18292002/diff/1/Tools/Scripts/webkitpy/layout_tests/port/factory.py#newcode104 Tools/Scripts/webkitpy/layout_tests/port/factory.py:104: # can't look at the port_name prefix in ...

7 years, 5 months ago (2013-06-30 18:23:27 UTC) #2

Steve Block

7 years, 5 months ago (2013-07-04 23:27:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r153597 (presubmit successful).

Expand Messages | Collapse Messages