Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1829113002: Ignore text updates where the size is 0 before and after for autocomplete. (Closed)

Created:
4 years, 9 months ago by Ted C
Modified:
4 years, 9 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore text updates where the size is 0 before and after for autocomplete. On Svelte devices, after clearing the text the IME was issuing a batch edit and adjusting the composing text with a 0 length string. We should ignore such updates. TEST=OmniboxTest#testRequestZeroSuggestAfterDelete (on L svelte) BUG=596906 Committed: https://crrev.com/8849b0dbc979ee32c24c4bc74cb1d09f06ea966e Cr-Commit-Position: refs/heads/master@{#383144}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ted C
PTAL
4 years, 9 months ago (2016-03-24 17:46:21 UTC) #2
newt (away)
lgtm
4 years, 9 months ago (2016-03-24 19:52:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829113002/1
4 years, 9 months ago (2016-03-24 20:17:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-24 21:00:18 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 21:01:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8849b0dbc979ee32c24c4bc74cb1d09f06ea966e
Cr-Commit-Position: refs/heads/master@{#383144}

Powered by Google App Engine
This is Rietveld 408576698