chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java - Issue 1829113002: Ignore text updates where the size is 0 before and after for autocomplete.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java

Issue 1829113002: Ignore text updates where the size is 0 before and after for autocomplete. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java

index b547da656a6657010204e6dbde74a09220e29306..837717d66336b585e0c9d563baf14bc97c137b41 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java

@@ -374,8 +374,11 @@ public class UrlBar extends VerticallyFixedEditText {

mSelectionChangedInBatchMode = false;

}

- boolean textDeleted = getText().length() < mBeforeBatchEditLength;

- notifyAutocompleteTextStateChanged(textDeleted);

+ int currentTextLength = getText().length();

+ if (currentTextLength != 0 || mBeforeBatchEditLength != 0) {

+ boolean textDeleted = currentTextLength < mBeforeBatchEditLength;

+ notifyAutocompleteTextStateChanged(textDeleted);

+ }

mBeforeBatchEditLength = 0;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »