Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/GraphicsContextState.cpp

Issue 1829093002: Use sk_sp-based APIs for SkColorFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to reviews Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/graphics/GraphicsContextState.h" 5 #include "platform/graphics/GraphicsContextState.h"
6 6
7 #include "platform/graphics/skia/SkiaUtils.h" 7 #include "platform/graphics/skia/SkiaUtils.h"
8 8
9 namespace blink { 9 namespace blink {
10 10
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 m_fillPaint.setLooper(0); 150 m_fillPaint.setLooper(0);
151 } 151 }
152 152
153 void GraphicsContextState::setLineDash(const DashArray& dashes, float dashOffset ) 153 void GraphicsContextState::setLineDash(const DashArray& dashes, float dashOffset )
154 { 154 {
155 m_strokeData.setLineDash(dashes, dashOffset); 155 m_strokeData.setLineDash(dashes, dashOffset);
156 } 156 }
157 157
158 void GraphicsContextState::setColorFilter(PassRefPtr<SkColorFilter> colorFilter) 158 void GraphicsContextState::setColorFilter(PassRefPtr<SkColorFilter> colorFilter)
159 { 159 {
160 m_colorFilter = colorFilter; 160 m_colorFilter = toSkSp(colorFilter);
f(malita) 2016/03/28 13:39:32 Hmm, looking at this code I wonder why we need m_c
161 m_strokePaint.setColorFilter(m_colorFilter.get()); 161 m_strokePaint.setColorFilter(m_colorFilter);
162 m_fillPaint.setColorFilter(m_colorFilter.get()); 162 m_fillPaint.setColorFilter(m_colorFilter);
163 } 163 }
164 164
165 void GraphicsContextState::setInterpolationQuality(InterpolationQuality quality) 165 void GraphicsContextState::setInterpolationQuality(InterpolationQuality quality)
166 { 166 {
167 m_interpolationQuality = quality; 167 m_interpolationQuality = quality;
168 m_strokePaint.setFilterQuality(filterQualityForPaint(quality)); 168 m_strokePaint.setFilterQuality(filterQualityForPaint(quality));
169 m_fillPaint.setFilterQuality(filterQualityForPaint(quality)); 169 m_fillPaint.setFilterQuality(filterQualityForPaint(quality));
170 } 170 }
171 171
172 void GraphicsContextState::setShouldAntialias(bool shouldAntialias) 172 void GraphicsContextState::setShouldAntialias(bool shouldAntialias)
173 { 173 {
174 m_shouldAntialias = shouldAntialias; 174 m_shouldAntialias = shouldAntialias;
175 m_strokePaint.setAntiAlias(shouldAntialias); 175 m_strokePaint.setAntiAlias(shouldAntialias);
176 m_fillPaint.setAntiAlias(shouldAntialias); 176 m_fillPaint.setAntiAlias(shouldAntialias);
177 } 177 }
178 178
179 } // namespace blink 179 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698