Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3246)

Unified Diff: cc/playback/compositing_display_item.cc

Issue 1829093002: Use sk_sp-based APIs for SkColorFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to reviews Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/playback/compositing_display_item.cc
diff --git a/cc/playback/compositing_display_item.cc b/cc/playback/compositing_display_item.cc
index 548f54a5dc72197d7d09d8a3c7ff3f285613caf5..0d75ca9a6bb2e98ed16e974484cfe9d81a2f80c8 100644
--- a/cc/playback/compositing_display_item.cc
+++ b/cc/playback/compositing_display_item.cc
@@ -27,7 +27,7 @@ CompositingDisplayItem::CompositingDisplayItem(
uint8_t alpha,
SkXfermode::Mode xfermode,
SkRect* bounds,
- skia::RefPtr<SkColorFilter> cf,
+ sk_sp<SkColorFilter> cf,
bool lcd_text_requires_opaque_layer) {
SetNew(alpha, xfermode, bounds, std::move(cf),
lcd_text_requires_opaque_layer);
@@ -46,12 +46,12 @@ CompositingDisplayItem::CompositingDisplayItem(
new SkRect(gfx::RectFToSkRect(ProtoToRectF(details.bounds()))));
}
- skia::RefPtr<SkColorFilter> filter;
+ sk_sp<SkColorFilter> filter;
if (details.has_color_filter()) {
SkFlattenable* flattenable = SkValidatingDeserializeFlattenable(
details.color_filter().c_str(), details.color_filter().size(),
SkColorFilter::GetFlattenableType());
- filter = skia::AdoptRef(static_cast<SkColorFilter*>(flattenable));
+ filter.reset(static_cast<SkColorFilter*>(flattenable));
}
bool lcd_text_requires_opaque_layer =
@@ -67,7 +67,7 @@ CompositingDisplayItem::~CompositingDisplayItem() {
void CompositingDisplayItem::SetNew(uint8_t alpha,
SkXfermode::Mode xfermode,
SkRect* bounds,
- skia::RefPtr<SkColorFilter> cf,
+ sk_sp<SkColorFilter> cf,
bool lcd_text_requires_opaque_layer) {
alpha_ = alpha;
xfermode_ = xfermode;
@@ -106,7 +106,7 @@ void CompositingDisplayItem::Raster(
SkPaint paint;
paint.setXfermodeMode(xfermode_);
paint.setAlpha(alpha_);
- paint.setColorFilter(color_filter_.get());
+ paint.setColorFilter(color_filter_);
const SkRect* bounds = has_bounds_ ? &bounds_ : nullptr;
if (lcd_text_requires_opaque_layer_)
canvas->saveLayer(bounds, &paint);

Powered by Google App Engine
This is Rietveld 408576698