Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: components/gcm_driver/instance_id/instance_id_test_utils_android.h

Issue 1829023002: Add fake for InstanceIDWithSubtype.java, in order to re-use unit test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid2jni
Patch Set: Move FakeInstanceIDWithSubtype to javatests/ Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/instance_id/instance_id_test_utils_android.h
diff --git a/components/gcm_driver/instance_id/instance_id_test_utils_android.h b/components/gcm_driver/instance_id/instance_id_test_utils_android.h
new file mode 100644
index 0000000000000000000000000000000000000000..ed385c631fb8e2d4a3d3a415803e463e59cbecf4
--- /dev/null
+++ b/components/gcm_driver/instance_id/instance_id_test_utils_android.h
@@ -0,0 +1,28 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_GCM_DRIVER_INSTANCE_ID_INSTANCE_ID_TEST_UTILS_ANDROID_H_
+#define COMPONENTS_GCM_DRIVER_INSTANCE_ID_INSTANCE_ID_TEST_UTILS_ANDROID_H_
+
+#include <jni.h>
+
+#include "base/macros.h"
+
+namespace instance_id {
+
+class InstanceIDTestUtilsAndroid {
+ public:
+ // Register JNI methods.
+ static bool RegisterJni(JNIEnv* env);
Peter Beverloo 2016/04/15 00:00:18 You never call this anywhere?
johnme 2016/04/15 16:00:43 Blarg. Turns out it doesn't even do anything. Adde
+
+ // Call this (with use_fake=true) in SetUp of all tests using Instance IDs.
Peter Beverloo 2016/04/15 00:00:18 This is not really helpful. Document what it does
johnme 2016/04/15 16:00:43 Done.
+ static void ClearDataAndSetUseFakeForTesting(bool use_fake);
+
+ private:
+ DISALLOW_IMPLICIT_CONSTRUCTORS(InstanceIDTestUtilsAndroid);
+};
+
+} // namespace instance_id
+
+#endif // COMPONENTS_GCM_DRIVER_INSTANCE_ID_INSTANCE_ID_TEST_UTILS_ANDROID_H_

Powered by Google App Engine
This is Rietveld 408576698