Add fake for InstanceIDWithSubtype.java, in order to re-use unit test

components/gcm_driver/instance_id/instance_id_test_utils_android.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_GCM_DRIVER_INSTANCE_ID_INSTANCE_ID_TEST_UTILS_ANDROID_H_
+#define COMPONENTS_GCM_DRIVER_INSTANCE_ID_INSTANCE_ID_TEST_UTILS_ANDROID_H_
+
+#include <jni.h>
+
+#include "base/macros.h"
+
+namespace instance_id {
+
+class InstanceIDTestUtilsAndroid {
+ public:
+  // Register JNI methods.
+  static bool RegisterJni(JNIEnv* env);

[Peter Beverloo, 2016/04/15 00:00:18]

You never call this anywhere?

[johnme, 2016/04/15 16:00:43]

Blarg. Turns out it doesn't even do anything. Added it to
components/test/run_all_unittests.cc and filed https://crbug.com/603936 to nuke
it.

+
+  // Call this (with use_fake=true) in SetUp of all tests using Instance IDs.

[Peter Beverloo, 2016/04/15 00:00:18]

This is not really helpful. Document what it does and why it's necessary,
similar to the other comment.

[johnme, 2016/04/15 16:00:43]

Done.

+  static void ClearDataAndSetUseFakeForTesting(bool use_fake);
+
+ private:
+  DISALLOW_IMPLICIT_CONSTRUCTORS(InstanceIDTestUtilsAndroid);
+};
+
+}  // namespace instance_id
+
+#endif  // COMPONENTS_GCM_DRIVER_INSTANCE_ID_INSTANCE_ID_TEST_UTILS_ANDROID_H_