Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4475)

Unified Diff: chrome/browser/extensions/api/system_info_display/display_info_provider.h

Issue 18290002: [SystemInfo API] Finish TODOs in SystemInfoProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dev_rewrite_storage_info_api
Patch Set: Fix hongbo's comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/system_info_display/display_info_provider.h
diff --git a/chrome/browser/extensions/api/system_info_display/display_info_provider.h b/chrome/browser/extensions/api/system_info_display/display_info_provider.h
index 5820ff502975098f2ef51d9332145ffdd13e8c66..63a7077b8fdd217e4200b0f53e3851d19b1bd543 100644
--- a/chrome/browser/extensions/api/system_info_display/display_info_provider.h
+++ b/chrome/browser/extensions/api/system_info_display/display_info_provider.h
@@ -17,7 +17,7 @@ typedef std::vector<linked_ptr<
class DisplayInfoProvider : public SystemInfoProvider<DisplayInfo> {
public:
- typedef base::Callback<void(const DisplayInfo& info, bool success)>
+ typedef base::Callback<void(bool success)>
RequestInfoCallback;
typedef base::Callback<void(bool success, const std::string& error)>
SetInfoCallback;
@@ -42,10 +42,12 @@ class DisplayInfoProvider : public SystemInfoProvider<DisplayInfo> {
const api::system_info_display::DisplayProperties& info,
const SetInfoCallback& callback);
+ const DisplayInfo& display_info() const;
+
protected:
// Overriden from SystemInfoProvider<DisplayInfo>.
// The implementation is platform specific.
- virtual bool QueryInfo(DisplayInfo* info) OVERRIDE;
+ virtual bool QueryInfo() OVERRIDE;
friend class SystemInfoProvider<DisplayInfo>;

Powered by Google App Engine
This is Rietveld 408576698