chrome/browser/extensions/api/system_info_cpu/system_info_cpu_apitest.cc - Issue 18290002: [SystemInfo API] Finish TODOs in SystemInfoProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/system_info_cpu/system_info_cpu_apitest.cc

Issue 18290002: [SystemInfo API] Finish TODOs in SystemInfoProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dev_rewrite_storage_info_api

Patch Set: Fix hongbo's comments Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/system_info/system_info_provider.h ('K') | « chrome/browser/extensions/api/system_info_cpu/system_info_cpu_api.cc ('k') | chrome/browser/extensions/api/system_info_display/display_info_provider.h » ('j') | chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/system_info_cpu/system_info_cpu_apitest.cc

diff --git a/chrome/browser/extensions/api/system_info_cpu/system_info_cpu_apitest.cc b/chrome/browser/extensions/api/system_info_cpu/system_info_cpu_apitest.cc

index 149a60c48b8a430993baaf8f4ffdb41bcfaba361..705b91c5abc29f1fee387f6f4553e3788e266401 100644

--- a/chrome/browser/extensions/api/system_info_cpu/system_info_cpu_apitest.cc

+++ b/chrome/browser/extensions/api/system_info_cpu/system_info_cpu_apitest.cc

@@ -17,13 +17,11 @@ class MockCpuInfoProviderImpl : public CpuInfoProvider {

public:

MockCpuInfoProviderImpl() {}

- virtual bool QueryInfo(CpuInfo* info) OVERRIDE {

- if (!info) return false;

+ virtual bool QueryInfo() OVERRIDE {

+ CpuInfo* info = &info_;

info->num_of_processors = 4;

info->arch_name = "x86";

info->model_name = "unknown";

return true;

}