Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1828983002: Revert of [DevTools] Use InspectorFrontendHost.readyForTest for layout tests. (Closed)

Created:
4 years, 9 months ago by battre
Modified:
4 years, 9 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, caseq+blink_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, jam, lushnikov+blink_chromium.org, blink-reviews-api_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, mkwst+moarreviews-shell_chromium.org, sergeyv+blink_chromium.org, jochen+watch_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ready-for-test
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Use InspectorFrontendHost.readyForTest for layout tests. (patchset #3 id:40001 of https://codereview.chromium.org/1819243002/ ) Reason for revert: http/tests/inspector/resource-tree/resource-tree-reload.html is flaky BUG=597572 Original issue's description: > [DevTools] Use InspectorFrontendHost.readyForTest for layout tests. > > BUG=none > > Committed: https://crrev.com/89f7238cebbf5d77e4caa84d0a2750f6faa7e983 > Cr-Commit-Position: refs/heads/master@{#383015} TBR=pfeldman@chromium.org,dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/46c66a666056b2bca1e991442a42e09af4cbee5b Cr-Commit-Position: refs/heads/master@{#383053}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -126 lines) Patch
M chrome/browser/devtools/devtools_window.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/devtools/devtools_window_testing.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M components/test_runner/web_test_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/layout_test/blink_test_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/layout_test/blink_test_controller.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_devtools_frontend.h View 2 chunks +0 lines, -7 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_devtools_frontend.cc View 3 chunks +1 line, -45 lines 0 comments Download
M content/shell/browser/shell_devtools_frontend.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/common/shell_messages.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html View 3 chunks +16 lines, -21 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/json-parse.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInspectorAgent.h View 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInspectorAgent.cpp View 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/devtools.js View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHostAPI.js View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 2 chunks +14 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebDevToolsAgent.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
battre
Created Revert of [DevTools] Use InspectorFrontendHost.readyForTest for layout tests.
4 years, 9 months ago (2016-03-24 11:51:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1828983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1828983002/1
4 years, 9 months ago (2016-03-24 11:51:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-24 11:52:36 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 11:53:40 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46c66a666056b2bca1e991442a42e09af4cbee5b
Cr-Commit-Position: refs/heads/master@{#383053}

Powered by Google App Engine
This is Rietveld 408576698