content/shell/browser/layout_test/layout_test_devtools_frontend.h - Issue 1828983002: Revert of [DevTools] Use InspectorFrontendHost.readyForTest for layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_devtools_frontend.h

Issue 1828983002: Revert of [DevTools] Use InspectorFrontendHost.readyForTest for layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ready-for-test

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/browser/layout_test/blink_test_controller.cc ('k') | content/shell/browser/layout_test/layout_test_devtools_frontend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/layout_test_devtools_frontend.h

diff --git a/content/shell/browser/layout_test/layout_test_devtools_frontend.h b/content/shell/browser/layout_test/layout_test_devtools_frontend.h

index 839a9a56938c349713a5ae5bf8adbfdf85b71291..db2dc4168dc9a00d9d9d8bff924748ff258147ec 100644

--- a/content/shell/browser/layout_test/layout_test_devtools_frontend.h

+++ b/content/shell/browser/layout_test/layout_test_devtools_frontend.h

@@ -26,7 +26,6 @@

void ReuseFrontend(const std::string& settings,

const std::string frontend_url);

- void EvaluateInFrontend(int call_id, const std::string& expression);

private:

LayoutTestDevToolsFrontend(Shell* frontend_shell,

@@ -36,14 +35,8 @@

// content::DevToolsAgentHostClient implementation.

void AgentHostClosed(DevToolsAgentHost* agent_host, bool replaced) override;

- // ShellDevToolsFrontend overrides.

- void HandleMessageFromDevToolsFrontend(const std::string& message) override;

// WebContentsObserver implementation.

void RenderProcessGone(base::TerminationStatus status) override;

- bool ready_for_test_;

- std::vector<std::pair<int, std::string>> pending_evaluations_;

DISALLOW_COPY_AND_ASSIGN(LayoutTestDevToolsFrontend);

};