Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1828853002: Merge to M50: Fix accessible focus state on menu bar container. (Closed)

Created:
4 years, 9 months ago by dmazzoni
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Merge to M50: Fix accessible focus state on menu bar container. When the Chrome menu is open, we use a role of "menu bar" for the outer pop-up container, "menu" inside of that, and "menu item" for each item. One screen reader, NVDA, ignores focus events inside the menu unless the menu bar indicates that it's focused. This code was moved from cross-platform code to Windows-specific code in r376339 when we switched to keeping track of focus globally, but unfortunately it broke because we don't keep track of focus inside the menu pop-up. So for now as a quick fix, just mark the menu bar role as focused when visible. This will work fine because this is the only place we use the menu bar role and it's only visible when the menu is popped up. Later a better fix would be to properly track focus inside the menu pop-up. Tested manually with NVDA. BUG=593589 Review URL: https://codereview.chromium.org/1801183002 Cr-Commit-Position: refs/heads/master@{#381320} (cherry picked from commit 34bf4c64e98f95f62d37891f45a945076c506a56) Committed: https://chromium.googlesource.com/chromium/src/+/d301ea79b9a13f2d6dbed1afbf1b0ba4b8675e74

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M ui/accessibility/platform/ax_platform_node_win.cc View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dmazzoni
4 years, 9 months ago (2016-03-24 04:38:30 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d301ea79b9a13f2d6dbed1afbf1b0ba4b8675e74.

Powered by Google App Engine
This is Rietveld 408576698