Fix accessible focus state on menu bar container.

Fix accessible focus state on menu bar container.

When the Chrome menu is open, we use a role of "menu bar" for the outer
pop-up container, "menu" inside of that, and "menu item" for each item.
One screen reader, NVDA, ignores focus events inside the menu unless the
menu bar indicates that it's focused.

This code was moved from cross-platform code to Windows-specific code in
r376339 when we switched to keeping track of focus globally, but
unfortunately it broke because we don't keep track of focus inside
the menu pop-up.

So for now as a quick fix, just mark the menu bar role as focused when
visible. This will work fine because this is the only place we use the
menu bar role and it's only visible when the menu is popped up. Later
a better fix would be to properly track focus inside the menu pop-up.

Tested manually with NVDA.

BUG=593589
Committed: https://crrev.com/34bf4c64e98f95f62d37891f45a945076c506a56
Cr-Commit-Position: refs/heads/master@{#381320}

[dmazzoni, 2016-03-15 17:52:02]

dmazzoni@chromium.org changed reviewers:
+ nektar@chromium.org

[nektarios, 2016-03-15 21:23:30]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2016-03-15 21:23:30]

lgtm

[commit-bot: I haz the power, 2016-03-15 21:23:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1801183002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1801183002/1

[commit-bot: I haz the power, 2016-03-15 21:30:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-15 21:32:24]

Description was changed from

==========
Fix accessible focus state on menu bar container.

When the Chrome menu is open, we use a role of "menu bar" for the outer
pop-up container, "menu" inside of that, and "menu item" for each item.
One screen reader, NVDA, ignores focus events inside the menu unless the
menu bar indicates that it's focused.

This code was moved from cross-platform code to Windows-specific code in
r376339 when we switched to keeping track of focus globally, but
unfortunately it broke because we don't keep track of focus inside
the menu pop-up.

So for now as a quick fix, just mark the menu bar role as focused when
visible. This will work fine because this is the only place we use the
menu bar role and it's only visible when the menu is popped up. Later
a better fix would be to properly track focus inside the menu pop-up.

Tested manually with NVDA.

BUG=593589
==========

to

==========
Fix accessible focus state on menu bar container.

When the Chrome menu is open, we use a role of "menu bar" for the outer
pop-up container, "menu" inside of that, and "menu item" for each item.
One screen reader, NVDA, ignores focus events inside the menu unless the
menu bar indicates that it's focused.

This code was moved from cross-platform code to Windows-specific code in
r376339 when we switched to keeping track of focus globally, but
unfortunately it broke because we don't keep track of focus inside
the menu pop-up.

So for now as a quick fix, just mark the menu bar role as focused when
visible. This will work fine because this is the only place we use the
menu bar role and it's only visible when the menu is popped up. Later
a better fix would be to properly track focus inside the menu pop-up.

Tested manually with NVDA.

BUG=593589

Committed: https://crrev.com/34bf4c64e98f95f62d37891f45a945076c506a56
Cr-Commit-Position: refs/heads/master@{#381320}
==========

[commit-bot: I haz the power, 2016-03-15 21:32:25]

Patchset 1 (id:??) landed as
https://crrev.com/34bf4c64e98f95f62d37891f45a945076c506a56
Cr-Commit-Position: refs/heads/master@{#381320}

[tommi (sloooow) - chröme, 2016-03-16 16:28:04]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1806943002/ by tommi@chromium.org.

The reason for reverting is: I'm speculatively reverting this cl since webkit
tests started failing on Windows. See here for example:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%...

webkit_tests webkit_tests 
unexpected_failures:
virtual/scalefactor150/fast/hidpi/static/calendar-picker-appearance.html
virtual/scalefactor150/fast/hidpi/static/data-suggestion-picker-appearance.html
virtual/scalefactor150/fast/hidpi/static/popup-menu-appearance.html.

[dmazzoni, 2016-03-16 16:55:39]

I think this change is probably unrelated to those failures, but feel free
to let the bots cycle to see.

On Wed, Mar 16, 2016 at 9:28 AM <tommi@chromium.org> wrote:

> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1806943002/ by tommi@chromium.org.
>
> The reason for reverting is: I'm speculatively reverting this cl since
> webkit
> tests started failing on Windows. See here for example:
>
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%...
>
> webkit_tests webkit_tests
> unexpected_failures:
> virtual/scalefactor150/fast/hidpi/static/calendar-picker-appearance.html
>
>
virtual/scalefactor150/fast/hidpi/static/data-suggestion-picker-appearance.html
> virtual/scalefactor150/fast/hidpi/static/popup-menu-appearance.html.
>
> https://codereview.chromium.org/1801183002/
>
> --
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2016-03-16 17:14:43]

Yes, I suspected that. Will reland if this has no effect. Sorry for the
inconvenience.

On Wed, Mar 16, 2016, 17:55 Dominic Mazzoni <dmazzoni@chromium.org> wrote:

> I think this change is probably unrelated to those failures, but feel free
> to let the bots cycle to see.
>
> On Wed, Mar 16, 2016 at 9:28 AM <tommi@chromium.org> wrote:
>
>> A revert of this CL (patchset #1 id:1) has been created in
>> https://codereview.chromium.org/1806943002/ by tommi@chromium.org.
>>
>> The reason for reverting is: I'm speculatively reverting this cl since
>> webkit
>> tests started failing on Windows. See here for example:
>>
>>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%...
>>
>> webkit_tests webkit_tests
>> unexpected_failures:
>> virtual/scalefactor150/fast/hidpi/static/calendar-picker-appearance.html
>>
>>
virtual/scalefactor150/fast/hidpi/static/data-suggestion-picker-appearance.html
>> virtual/scalefactor150/fast/hidpi/static/popup-menu-appearance.html.
>>
>> https://codereview.chromium.org/1801183002/
>>
>> --
>>
> You received this message because you are subscribed to the Google Groups
>> "Chromium-reviews" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to chromium-reviews+unsubscribe@chromium.org.
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.