Simplify resolve.

Simplify resolve.

BUG=

Committed: https://crrev.com/71bb0096a02097ca761be2404e0645315674a77b
Cr-Commit-Position: refs/heads/master@{#383024}

[Ben Goodger (Google), 2016-03-23 22:10:42]

ben@chromium.org changed reviewers:
+ sky@chromium.org

[Ben Goodger (Google), 2016-03-23 22:10:42]

This eliminates the Reader class (heh) and coalesces the various parameters
returned via ResolveMojoName into one ResolveResult mojom struct.

The various data structures that were once held in Catalog are now inferred from
the Entrys. Catalog now has a simple name->Entry map.

I still haven't invented the user package dir yet but the groundwork is paved
for it.

[sky, 2016-03-23 23:42:37]

https://codereview.chromium.org/1828803002/diff/60001/mojo/services/catalog/c...
File mojo/services/catalog/catalog.cc (left):

https://codereview.chromium.org/1828803002/diff/60001/mojo/services/catalog/c...
mojo/services/catalog/catalog.cc:208: qualifiers_[entry->name()] =
entry->qualifier();
How come the qualifiers_ is getting removed? Isn't that needed? Isn't it used
for things like chrome --mash?

https://codereview.chromium.org/1828803002/diff/60001/mojo/services/catalog/c...
File mojo/services/catalog/catalog.cc (right):

https://codereview.chromium.org/1828803002/diff/60001/mojo/services/catalog/c...
mojo/services/catalog/catalog.cc:28: else if (type == "exe")
nit: no need for else.

https://codereview.chromium.org/1828803002/diff/60001/mojo/services/catalog/c...
mojo/services/catalog/catalog.cc:36: if (type == "mojo") {
nit: would be nice to have these constants defined somewhere.

https://codereview.chromium.org/1828803002/diff/60001/mojo/services/catalog/c...
mojo/services/catalog/catalog.cc:40: } else if (type == "exe") {
nit: no else.

https://codereview.chromium.org/1828803002/diff/60001/mojo/services/catalog/c...
mojo/services/catalog/catalog.cc:62: return make_scoped_ptr(result);
nit: use scoped_ptr at 59 and return said scoped_ptr here (less error prone if
you ever early return).

[Ben Goodger (Google), 2016-03-23 23:52:49]

Updated ptal

https://codereview.chromium.org/1828803002/diff/60001/mojo/services/catalog/c...
File mojo/services/catalog/catalog.cc (left):

https://codereview.chromium.org/1828803002/diff/60001/mojo/services/catalog/c...
mojo/services/catalog/catalog.cc:208: qualifiers_[entry->name()] =
entry->qualifier();
On 2016/03/23 23:42:37, sky wrote:
> How come the qualifiers_ is getting removed? Isn't that needed? Isn't it used
> for things like chrome --mash?

The qualifier is stored in the Entry, and passed back via the
Entry->ResolveResult type converter.

[sky, 2016-03-24 00:03:42]

LGTM

[Ben Goodger (Google), 2016-03-24 02:44:02]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-03-24 02:44:02]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1828803002/#ps100001
(title: ".")

[commit-bot: I haz the power, 2016-03-24 02:44:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1828803002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1828803002/100001

[commit-bot: I haz the power, 2016-03-24 03:43:16]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-03-24 03:44:16]

Description was changed from

==========
Simplify resolve.

BUG=
==========

to

==========
Simplify resolve.

BUG=

Committed: https://crrev.com/71bb0096a02097ca761be2404e0645315674a77b
Cr-Commit-Position: refs/heads/master@{#383024}
==========

[commit-bot: I haz the power, 2016-03-24 03:44:17]

Patchset 6 (id:??) landed as
https://crrev.com/71bb0096a02097ca761be2404e0645315674a77b
Cr-Commit-Position: refs/heads/master@{#383024}