Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Unified Diff: mojo/shell/shell.h

Issue 1828803002: Simplify resolve. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@61catalog
Patch Set: . Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/public/interfaces/shell_resolver.mojom ('k') | mojo/shell/shell.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/shell.h
diff --git a/mojo/shell/shell.h b/mojo/shell/shell.h
index c060518034b2f5513b7a0fb8125384e2c750e675..60c5dadbba229e794e0ea5118208ee146cde7777 100644
--- a/mojo/shell/shell.h
+++ b/mojo/shell/shell.h
@@ -142,18 +142,11 @@ class Shell : public ShellClient {
// |params| are the params passed to Connect().
// |client| if provided is a ShellClientPtr which should be used to manage the
// new application instance. This may be null.
- // |resolved_name| is the mojo: name identifying the physical package
- // application.
- // |file_url| is the resolved file:// URL of the physical package.
- // |capabilities| is the CapabilitySpecPtr the requested application should be
- // run with, from its manifest.
+ // |result| contains the result of the resolve operation.
void OnGotResolvedName(mojom::ShellResolverPtr resolver,
scoped_ptr<ConnectParams> params,
mojom::ShellClientPtr client,
- const String& resolved_name,
- const String& resolved_instance,
- mojom::CapabilitySpecPtr capabilities,
- const String& file_url);
+ mojom::ResolveResultPtr result);
// Tries to load |target| with an Loader. Returns true if one was registered
// and it was loaded, in which case |request| is taken.
« no previous file with comments | « mojo/shell/public/interfaces/shell_resolver.mojom ('k') | mojo/shell/shell.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698