[Extensions] Convert APIs to use movable types [2]

[Extensions] Convert APIs to use movable types [2]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Nowe, we can make these types movable. Update the following APIs
to use movable types in this CL:
- bookmark_manager_private.json
- bookmarks.json
- braille_display_private.idl
- browser_action.json

BUG=595949
Committed: https://crrev.com/fa7d4b31e34874d58cae9a35f65d8bf2f9b9bab5
Cr-Commit-Position: refs/heads/master@{#383119}

[Devlin, 2016-03-23 05:24:41]

Description was changed from

==========
chrome/test/data/extensions/blocked_actions/content_scripts/script.js           
|   9 +++++
[Extensions] Convert APIs to use movable types []

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Nowe, we can make these types movable. Update the following APIs
to use movable types in this CL:
- bookmark_manager_private.json
- bookmarks.json
- braille_display_private.idl
- browser_action.json

BUG=595949
==========

to

==========
[Extensions] Convert APIs to use movable types [2]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Nowe, we can make these types movable. Update the following APIs
to use movable types in this CL:
- bookmark_manager_private.json
- bookmarks.json
- braille_display_private.idl
- browser_action.json

BUG=595949
==========

[Devlin, 2016-03-23 14:17:54]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-03-23 14:18:08]

Patchset #1 (id:20001) has been deleted

[Devlin, 2016-03-23 14:40:39]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Devlin, 2016-03-23 14:40:39]

Istiaque, mind taking a look?  (I'll be splitting these reviews between you and
Antony.)

[lazyboy, 2016-03-23 20:31:38]

lgtm

https://codereview.chromium.org/1828633002/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc (right):

https://codereview.chromium.org/1828633002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc:38:
nodes->push_back(std::move(new_node));
Can this be nodes->push_back(GetBookmarkTreeNode(...)) instead of using explicit
std::move?
Given BookmarkTreeNode is non-copyable, this should be fine right?

https://codereview.chromium.org/1828633002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc:102:
children.push_back(std::move(child_node));
Same question as above.

[Devlin, 2016-03-24 18:40:24]

https://codereview.chromium.org/1828633002/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc (right):

https://codereview.chromium.org/1828633002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc:38:
nodes->push_back(std::move(new_node));
On 2016/03/23 20:31:38, lazyboy wrote:
> Can this be nodes->push_back(GetBookmarkTreeNode(...)) instead of using
explicit
> std::move?
> Given BookmarkTreeNode is non-copyable, this should be fine right?

Yep!  Done.

https://codereview.chromium.org/1828633002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc:102:
children.push_back(std::move(child_node));
On 2016/03/23 20:31:38, lazyboy wrote:
> Same question as above.

Done.

[Devlin, 2016-03-24 18:40:29]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-03-24 18:40:29]

The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/1828633002/#ps60001
(title: "Istiaque's")

[commit-bot: I haz the power, 2016-03-24 18:40:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1828633002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1828633002/60001

[commit-bot: I haz the power, 2016-03-24 19:27:14]

Description was changed from

==========
[Extensions] Convert APIs to use movable types [2]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Nowe, we can make these types movable. Update the following APIs
to use movable types in this CL:
- bookmark_manager_private.json
- bookmarks.json
- braille_display_private.idl
- browser_action.json

BUG=595949
==========

to

==========
[Extensions] Convert APIs to use movable types [2]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Nowe, we can make these types movable. Update the following APIs
to use movable types in this CL:
- bookmark_manager_private.json
- bookmarks.json
- braille_display_private.idl
- browser_action.json

BUG=595949
==========

[commit-bot: I haz the power, 2016-03-24 19:27:16]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-03-24 19:29:00]

Description was changed from

==========
[Extensions] Convert APIs to use movable types [2]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Nowe, we can make these types movable. Update the following APIs
to use movable types in this CL:
- bookmark_manager_private.json
- bookmarks.json
- braille_display_private.idl
- browser_action.json

BUG=595949
==========

to

==========
[Extensions] Convert APIs to use movable types [2]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Nowe, we can make these types movable. Update the following APIs
to use movable types in this CL:
- bookmark_manager_private.json
- bookmarks.json
- braille_display_private.idl
- browser_action.json

BUG=595949

Committed: https://crrev.com/fa7d4b31e34874d58cae9a35f65d8bf2f9b9bab5
Cr-Commit-Position: refs/heads/master@{#383119}
==========

[commit-bot: I haz the power, 2016-03-24 19:29:01]

Patchset 2 (id:??) landed as
https://crrev.com/fa7d4b31e34874d58cae9a35f65d8bf2f9b9bab5
Cr-Commit-Position: refs/heads/master@{#383119}