Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6062)

Unified Diff: chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h

Issue 1828633002: [Extensions] Convert APIs to use movable types [2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Istiaque's Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h
diff --git a/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h b/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h
index b7d7216f73657648be59c84b63dd44fdca1a5c15..8135ad61098ebac578a2de03a9eca7090d5ff541 100644
--- a/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h
+++ b/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h
@@ -22,8 +22,7 @@ class ManagedBookmarkService;
namespace extensions {
namespace bookmark_api_helpers {
-// The returned value is owned by the caller.
-api::bookmarks::BookmarkTreeNode* GetBookmarkTreeNode(
+api::bookmarks::BookmarkTreeNode GetBookmarkTreeNode(
bookmarks::ManagedBookmarkService* managed,
const bookmarks::BookmarkNode* node,
bool recurse,
@@ -40,15 +39,14 @@ void PopulateBookmarkTreeNode(
// Adds a JSON representation of |node| to the JSON |nodes|.
void AddNode(bookmarks::ManagedBookmarkService* managed,
const bookmarks::BookmarkNode* node,
- std::vector<linked_ptr<api::bookmarks::BookmarkTreeNode>>* nodes,
+ std::vector<api::bookmarks::BookmarkTreeNode>* nodes,
bool recurse);
// Adds a JSON representation of |node| of folder type to the JSON |nodes|.
-void AddNodeFoldersOnly(
- bookmarks::ManagedBookmarkService* managed,
- const bookmarks::BookmarkNode* node,
- std::vector<linked_ptr<api::bookmarks::BookmarkTreeNode>>* nodes,
- bool recurse);
+void AddNodeFoldersOnly(bookmarks::ManagedBookmarkService* managed,
+ const bookmarks::BookmarkNode* node,
+ std::vector<api::bookmarks::BookmarkTreeNode>* nodes,
+ bool recurse);
// Remove node of |id|.
bool RemoveNode(bookmarks::BookmarkModel* model,

Powered by Google App Engine
This is Rietveld 408576698