Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1828543008: bindings: Fixes the regression of vm_working_set_final_size_total. (Closed)

Created:
4 years, 9 months ago by Yuki
Modified:
4 years, 8 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, auto-bisect-reviews_chromium.org, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bindings: Fixes the regression of vm_working_set_final_size_total. WIll reduce vm_working_set_final_size_total from 188489.28 to 175400.96. BUG=592310

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Synced. #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : Synced. #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -260 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h View 1 2 5 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp View 1 2 5 2 chunks +18 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface_base.cpp View 1 2 3 4 5 6 7 8 1 chunk +41 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp View 1 2 3 4 5 6 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp View 1 2 3 4 5 6 1 chunk +4 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.cpp View 1 2 3 4 5 6 1 chunk +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedGlobal.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedPrimaryGlobal.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp View 1 2 3 4 5 6 2 chunks +1 line, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp View 1 2 3 4 5 6 1 chunk +4 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp View 1 2 3 4 5 6 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp View 1 2 3 4 5 6 1 chunk +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp View 1 2 3 4 5 6 1 chunk +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp View 1 2 3 4 5 6 1 chunk +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp View 1 2 3 4 5 6 1 chunk +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.cpp View 1 2 3 4 5 6 1 chunk +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEmpty.cpp View 1 2 3 4 5 6 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventTarget.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp View 1 2 3 4 5 6 1 chunk +4 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp View 1 2 3 4 5 6 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp View 1 2 3 4 5 6 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.cpp View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 1 2 3 4 5 6 7 8 2 chunks +1 line, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp View 1 2 3 4 5 6 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp View 1 2 3 4 5 6 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp View 1 2 3 4 5 6 1 chunk +4 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp View 1 2 3 4 5 6 1 chunk +7 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Yuki
Could you review this CL?
4 years, 8 months ago (2016-04-04 08:12:32 UTC) #3
haraken
LGTM to try, but vm_working_set_final_size_total is a really noisy metric which is affected GC timing, ...
4 years, 8 months ago (2016-04-04 08:43:19 UTC) #4
Yuki
4 years, 8 months ago (2016-04-04 09:39:25 UTC) #5
On 2016/04/04 08:43:19, haraken wrote:
> LGTM to try, but vm_working_set_final_size_total is a really noisy metric
which
> is affected GC timing, measurement timing etc. If the regression is observed
> only in a limited number of benchmarks, I'm okay with ignoring it. *_peak_* is
a
> good metric but *_final_* is a bad metric (because the "final" totally depends
> on various timings)...

Okay, let me close the issue without landing this CL.

Powered by Google App Engine
This is Rietveld 408576698