third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp - Issue 1828543008: bindings: Fixes the regression of vm_working_set_final_size_total.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp

Issue 1828543008: bindings: Fixes the regression of vm_working_set_final_size_total. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp

index 78ea5f907c09eef67deca1e935894a3fceb1a8b0..2f734e4248ea8bd17c7bd37489a0890f91f6d2d4 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp

@@ -370,17 +370,13 @@ void V8TestInterfaceConstructor::constructorCallback(const v8::FunctionCallbackI

static void installV8TestInterfaceConstructorTemplate(v8::Local<v8::FunctionTemplate> interfaceTemplate, v8::Isolate* isolate)

{

// Initialize the interface object's template.

- V8DOMConfiguration::initializeDOMInterfaceTemplate(isolate, interfaceTemplate, V8TestInterfaceConstructor::wrapperTypeInfo.interfaceName, v8::Local<v8::FunctionTemplate>(), V8TestInterfaceConstructor::internalFieldCount);

- interfaceTemplate->SetCallHandler(V8TestInterfaceConstructor::constructorCallback);

- interfaceTemplate->SetLength(0);

v8::Local<v8::Signature> signature = v8::Signature::New(isolate, interfaceTemplate);

- ALLOW_UNUSED_LOCAL(signature);

v8::Local<v8::ObjectTemplate> instanceTemplate = interfaceTemplate->InstanceTemplate();

- ALLOW_UNUSED_LOCAL(instanceTemplate);

v8::Local<v8::ObjectTemplate> prototypeTemplate = interfaceTemplate->PrototypeTemplate();

- ALLOW_UNUSED_LOCAL(prototypeTemplate);

- // Register DOM constants, attributes and operations.

+ V8DOMConfiguration::initializeDOMInterfaceTemplate(isolate, interfaceTemplate, V8TestInterfaceConstructor::wrapperTypeInfo.interfaceName, v8::Local<v8::FunctionTemplate>(), instanceTemplate, prototypeTemplate, V8TestInterfaceConstructor::internalFieldCount, signature, nullptr, 0, nullptr, 0, nullptr, 0);

+ interfaceTemplate->SetCallHandler(V8TestInterfaceConstructor::constructorCallback);

+ interfaceTemplate->SetLength(0);

}

v8::Local<v8::FunctionTemplate> V8TestInterfaceConstructor::domTemplate(v8::Isolate* isolate)