Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2715)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/config/win/BUILD.gn

Issue 1828543003: clang/win: Stop passing -Qunused-arguments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: try to fix official Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/win/BUILD.gn
diff --git a/build/config/win/BUILD.gn b/build/config/win/BUILD.gn
index 7945cfc10066c4a1d15bdc649d37ab67b84ea6d7..d2792ef320df90e001f2b49b178dd2f20d17c460 100644
--- a/build/config/win/BUILD.gn
+++ b/build/config/win/BUILD.gn
@@ -33,10 +33,13 @@ config("compiler") {
cflags = [
"/Gy", # Enable function-level linking.
- "/GS", # Enable buffer security checking.
"/FS", # Preserve previous PDB behavior.
"/bigobj", # Some of our files are bigger than the regular limits.
]
+ if (!is_clang) {
+ # TODO(thakis): Enable this with clang too, https://crbug.com/598767
+ cflags += [ "/GS" ] # Enable buffer security checking.
+ }
# Force C/C++ mode for the given GN detected file type. This is necessary
# for precompiled headers where the same source file is compiled in both
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698