Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Side by Side Diff: Source/build/scripts/make_element_factory.py

Issue 182843002: Drop isindex from HTMLTagNames. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/build/scripts/make_element_type_helpers.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (C) 2013 Google Inc. All rights reserved. 2 # Copyright (C) 2013 Google Inc. All rights reserved.
3 # 3 #
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 71
72 interface_counts = defaultdict(int) 72 interface_counts = defaultdict(int)
73 tags = self._template_context['tags'] 73 tags = self._template_context['tags']
74 for tag in tags: 74 for tag in tags:
75 tag['has_js_interface'] = self._has_js_interface(tag) 75 tag['has_js_interface'] = self._has_js_interface(tag)
76 tag['js_interface'] = self._js_interface(tag) 76 tag['js_interface'] = self._js_interface(tag)
77 tag['interface'] = self._interface(tag) 77 tag['interface'] = self._interface(tag)
78 interface_counts[tag['interface']] += 1 78 interface_counts[tag['interface']] += 1
79 79
80 for tag in tags: 80 for tag in tags:
81 tag['multipleTagNames'] = interface_counts[tag['interface']] > 1 81 tag['multipleTagNames'] = (interface_counts[tag['interface']] > 1 or tag['interface'] == fallback_interface)
82 82
83 self._template_context.update({ 83 self._template_context.update({
84 'fallback_interface': fallback_interface, 84 'fallback_interface': fallback_interface,
85 'fallback_js_interface': fallback_js_interface, 85 'fallback_js_interface': fallback_js_interface,
86 }) 86 })
87 87
88 @template_expander.use_jinja('ElementFactory.h.tmpl', filters=filters) 88 @template_expander.use_jinja('ElementFactory.h.tmpl', filters=filters)
89 def generate_factory_header(self): 89 def generate_factory_header(self):
90 return self._template_context 90 return self._template_context
91 91
(...skipping 26 matching lines...) Expand all
118 if tag['JSInterfaceName']: 118 if tag['JSInterfaceName']:
119 return tag['JSInterfaceName'] 119 return tag['JSInterfaceName']
120 return self._interface(tag) 120 return self._interface(tag)
121 121
122 def _has_js_interface(self, tag): 122 def _has_js_interface(self, tag):
123 return not tag['noConstructor'] and self._js_interface(tag) != ('%sEleme nt' % self.namespace) 123 return not tag['noConstructor'] and self._js_interface(tag) != ('%sEleme nt' % self.namespace)
124 124
125 125
126 if __name__ == "__main__": 126 if __name__ == "__main__":
127 in_generator.Maker(MakeElementFactoryWriter).main(sys.argv) 127 in_generator.Maker(MakeElementFactoryWriter).main(sys.argv)
OLDNEW
« no previous file with comments | « no previous file | Source/build/scripts/make_element_type_helpers.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698