Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1828363002: views: remove the last function abstraction from browser_dialogs.h (Closed)

Created:
4 years, 9 months ago by tfarina
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

views: remove the last function abstraction from browser_dialogs.h After commit faed95410a75: ("views: remove unnecessary EditSearchEngine() function abstraction"), only CreateFindBar() function abstraction remained in browser_dialogs.h, but like EditSearchEngine(), it is unlikely this function will be used to be called by cross-platform code, so it is not necessary keep it wrapping FindBarHost. BrowserView can just depend on it like it does with many other chrome/browser/ui/views/ header files already. This is also what BrowserWindowCocoa does as well. This in effect get rid of browser_dialogs.h header file finally. BUG=None R=sky@chromium.org Committed: https://crrev.com/ba8376b3933223aa787273744c1bfd83f5574a15 Cr-Commit-Position: refs/heads/master@{#383282}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -42 lines) Patch
M chrome/browser/ui/views/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/ui/views/browser_dialogs.h View 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/browser/ui/views/content_setting_bubble_contents.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_host.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/user_manager_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/task_manager_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_ui_views.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
tfarina
4 years, 9 months ago (2016-03-24 22:35:30 UTC) #1
sky
LGTM
4 years, 9 months ago (2016-03-25 15:17:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1828363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1828363002/1
4 years, 9 months ago (2016-03-25 16:05:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-25 16:18:31 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 16:20:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba8376b3933223aa787273744c1bfd83f5574a15
Cr-Commit-Position: refs/heads/master@{#383282}

Powered by Google App Engine
This is Rietveld 408576698