Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: chrome/browser/ui/views/location_bar/location_bar_view.cc

Issue 1828363002: views: remove the last function abstraction from browser_dialogs.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/location_bar/location_bar_view.h" 5 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <map> 8 #include <map>
9 9
10 #include "base/i18n/rtl.h" 10 #include "base/i18n/rtl.h"
(...skipping 16 matching lines...) Expand all
27 #include "chrome/browser/translate/translate_service.h" 27 #include "chrome/browser/translate/translate_service.h"
28 #include "chrome/browser/ui/autofill/save_card_bubble_controller_impl.h" 28 #include "chrome/browser/ui/autofill/save_card_bubble_controller_impl.h"
29 #include "chrome/browser/ui/browser.h" 29 #include "chrome/browser/ui/browser.h"
30 #include "chrome/browser/ui/browser_finder.h" 30 #include "chrome/browser/ui/browser_finder.h"
31 #include "chrome/browser/ui/browser_window.h" 31 #include "chrome/browser/ui/browser_window.h"
32 #include "chrome/browser/ui/content_settings/content_setting_bubble_model.h" 32 #include "chrome/browser/ui/content_settings/content_setting_bubble_model.h"
33 #include "chrome/browser/ui/layout_constants.h" 33 #include "chrome/browser/ui/layout_constants.h"
34 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h" 34 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
35 #include "chrome/browser/ui/tabs/tab_strip_model.h" 35 #include "chrome/browser/ui/tabs/tab_strip_model.h"
36 #include "chrome/browser/ui/views/autofill/save_card_icon_view.h" 36 #include "chrome/browser/ui/views/autofill/save_card_icon_view.h"
37 #include "chrome/browser/ui/views/browser_dialogs.h"
38 #include "chrome/browser/ui/views/frame/browser_view.h" 37 #include "chrome/browser/ui/views/frame/browser_view.h"
39 #include "chrome/browser/ui/views/location_bar/background_with_1_px_border.h" 38 #include "chrome/browser/ui/views/location_bar/background_with_1_px_border.h"
40 #include "chrome/browser/ui/views/location_bar/content_setting_image_view.h" 39 #include "chrome/browser/ui/views/location_bar/content_setting_image_view.h"
41 #include "chrome/browser/ui/views/location_bar/keyword_hint_view.h" 40 #include "chrome/browser/ui/views/location_bar/keyword_hint_view.h"
42 #include "chrome/browser/ui/views/location_bar/location_bar_layout.h" 41 #include "chrome/browser/ui/views/location_bar/location_bar_layout.h"
43 #include "chrome/browser/ui/views/location_bar/location_icon_view.h" 42 #include "chrome/browser/ui/views/location_bar/location_icon_view.h"
44 #include "chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.h" 43 #include "chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.h"
45 #include "chrome/browser/ui/views/location_bar/page_action_image_view.h" 44 #include "chrome/browser/ui/views/location_bar/page_action_image_view.h"
46 #include "chrome/browser/ui/views/location_bar/page_action_with_badge_view.h" 45 #include "chrome/browser/ui/views/location_bar/page_action_with_badge_view.h"
47 #include "chrome/browser/ui/views/location_bar/selected_keyword_view.h" 46 #include "chrome/browser/ui/views/location_bar/selected_keyword_view.h"
(...skipping 1340 matching lines...) Expand 10 before | Expand all | Expand 10 after
1388 // LocationBarView, private TemplateURLServiceObserver implementation: 1387 // LocationBarView, private TemplateURLServiceObserver implementation:
1389 1388
1390 void LocationBarView::OnTemplateURLServiceChanged() { 1389 void LocationBarView::OnTemplateURLServiceChanged() {
1391 template_url_service_->RemoveObserver(this); 1390 template_url_service_->RemoveObserver(this);
1392 template_url_service_ = nullptr; 1391 template_url_service_ = nullptr;
1393 // If the browser is no longer active, let's not show the info bubble, as this 1392 // If the browser is no longer active, let's not show the info bubble, as this
1394 // would make the browser the active window again. 1393 // would make the browser the active window again.
1395 if (omnibox_view_ && omnibox_view_->GetWidget()->IsActive()) 1394 if (omnibox_view_ && omnibox_view_->GetWidget()->IsActive())
1396 ShowFirstRunBubble(); 1395 ShowFirstRunBubble();
1397 } 1396 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | chrome/browser/ui/views/profiles/user_manager_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698