Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 1828353002: Revert of Remove platform/NotImplemented.*. (Closed)

Created:
4 years, 9 months ago by Dirk Pranke
Modified:
4 years, 9 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-events_chromium.org, blink-reviews-html_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-worker-reviews_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dcheng, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, falken, f(malita), horo+watch_chromium.org, jsbell+serviceworker_chromium.org, Justin Novosad, kinuko+serviceworker, kinuko+watch, kinuko+worker_chromium.org, michaeln, mlamouri+watch-blink_chromium.org, nhiroki, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove platform/NotImplemented.*. (patchset #1 id:20001 of https://codereview.chromium.org/1820083005/ ) Reason for revert: We seem to be hitting logging all over the place for this, which is making buildbot very unhappy. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/62424/steps/webkit_tests/logs/stdio reverting for now. Original issue's description: > Remove platform/NotImplemented.*. > > We can use NOTIMPLEMENTED() macro, defined in base/logging.h, in Blink. > > BUG=596760 > > Committed: https://crrev.com/cdc755c0552ebca53e2a86d678a3dd7f7f5dbcf6 > Cr-Commit-Position: refs/heads/master@{#383029} TBR=haraken@chromium.org,yutak@chromium.org,tkent@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=596760

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -25 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTokenizer.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp View 6 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerObjectProxy.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediacapturefromelement/CanvasCaptureMediaStreamTrack.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediacapturefromelement/HTMLMediaElementCapture.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 5 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/Logging.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/Logging.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/NotImplemented.h View 1 chunk +50 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/NotImplemented.cpp View 1 chunk +41 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/PlatformKeyboardEvent.cpp View 3 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Assertions.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/Assertions.cpp View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Dirk Pranke
Created Revert of Remove platform/NotImplemented.*.
4 years, 9 months ago (2016-03-24 20:52:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1828353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1828353002/1
4 years, 9 months ago (2016-03-24 20:52:21 UTC) #2
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/wtf/Assertions.h: While running git apply --index -3 -p1; error: patch ...
4 years, 9 months ago (2016-03-24 20:53:10 UTC) #4
haraken
4 years, 9 months ago (2016-03-24 22:22:24 UTC) #7
Message was sent while issue was closed.
LGTM to revert.

Powered by Google App Engine
This is Rietveld 408576698