third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp - Issue 1828353002: Revert of Remove platform/NotImplemented.*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

Issue 1828353002: Revert of Remove platform/NotImplemented.*. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

index 34756932ef61a40c21d25199bc685a8a30244ace..d56b52a8fa20306c69c24e7c087fd147139a02df 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

@@ -25,6 +25,7 @@

#include "modules/webgl/WebGLUniformLocation.h"

#include "modules/webgl/WebGLVertexArrayObject.h"

#include "platform/CheckedInt.h"

+#include "platform/NotImplemented.h"

#include "public/platform/WebGraphicsContext3D.h"

#include "public/platform/WebGraphicsContext3DProvider.h"

#include "wtf/OwnPtr.h"

@@ -978,7 +979,7 @@

Vector<uint8_t> tempData;

if (data && (m_unpackFlipY || m_unpackPremultiplyAlpha)) {

// FIXME: WebGLImageConversion needs to be updated to accept image depth.

- NOTIMPLEMENTED();

+ notImplemented();

return;

}

@@ -1051,7 +1052,7 @@

bool changeUnpackParameters = false;

if (data && (m_unpackFlipY || m_unpackPremultiplyAlpha)) {

// FIXME: WebGLImageConversion needs to be updated to accept image depth.

- NOTIMPLEMENTED();

+ notImplemented();

changeUnpackParameters = true;

}

if (changeUnpackParameters)