Remove ASSERT_ARG().

Remove ASSERT_ARG().

ASSERT_ARG() is not much helpful than normal ASSERT() and DCHECK(). So this CL
removes it, and replaces existing call sites with DCHECK().

Also, this CL moves Node stream printers from testing code to production code
because they are used in DCHECK().

This relands crrev.com/383047 with just rebase.

BUG=596760
Committed: https://crrev.com/ec47b3501ce1e462c5721a870c9aabd0ef3581ab
Cr-Commit-Position: refs/heads/master@{#383236}

[tkent, 2016-03-24 06:29:33]

Description was changed from

==========
Remove ASSERT_ARG().

ASSERT_ARG() is not much helpful than normal ASSERT() or DCHECK(). So this CL
remvoes it, and replaces existing call sites with DCHECK().

Also, this CL moves Node stream printers from testing code to production code
because they are used in DCHECK().

BUG=596760
==========

to

==========
Remove ASSERT_ARG().

ASSERT_ARG() is not much helpful than normal ASSERT() and DCHECK(). So this CL
removes it, and replaces existing call sites with DCHECK().

Also, this CL moves Node stream printers from testing code to production code
because they are used in DCHECK().

BUG=596760
==========

[tkent, 2016-03-24 06:43:16]

tkent@chromium.org changed reviewers:
+ yosin@chromium.org

[tkent, 2016-03-24 06:43:16]

yosin@, would you review this please?

[yosin_UTC9, 2016-03-24 07:47:18]

lgtm

Thanks so much!
You make my life easier!

https://codereview.chromium.org/1828163002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Node.cpp (right):

https://codereview.chromium.org/1828163002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Node.cpp:1537: std::ostream&
operator<<(std::ostream& ostream, const Node& node)
Thanks!!

[yosin_UTC9, 2016-03-24 07:47:31]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-03-24 07:47:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1828163002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1828163002/20001

[commit-bot: I haz the power, 2016-03-24 09:57:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-24 09:58:34]

Description was changed from

==========
Remove ASSERT_ARG().

ASSERT_ARG() is not much helpful than normal ASSERT() and DCHECK(). So this CL
removes it, and replaces existing call sites with DCHECK().

Also, this CL moves Node stream printers from testing code to production code
because they are used in DCHECK().

BUG=596760
==========

to

==========
Remove ASSERT_ARG().

ASSERT_ARG() is not much helpful than normal ASSERT() and DCHECK(). So this CL
removes it, and replaces existing call sites with DCHECK().

Also, this CL moves Node stream printers from testing code to production code
because they are used in DCHECK().

BUG=596760

Committed: https://crrev.com/25e8e9a87ba795375862c9a33ae3d9704eebe489
Cr-Commit-Position: refs/heads/master@{#383047}
==========

[commit-bot: I haz the power, 2016-03-24 09:58:36]

Patchset 2 (id:??) landed as
https://crrev.com/25e8e9a87ba795375862c9a33ae3d9704eebe489
Cr-Commit-Position: refs/heads/master@{#383047}

[Dirk Pranke, 2016-03-24 21:25:52]

On 2016/03/24 09:58:36, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/25e8e9a87ba795375862c9a33ae3d9704eebe489
> Cr-Commit-Position: refs/heads/master@{#383047}

We seem to be hitting logging all over the place for this, which is making
buildbot very unhappy. 

>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/6...
> 
> reverting for now..

I ended up having to reverting this in
https://codereview.chromium.org/1826283004/ so that I could also revert
https://codereview.chromium.org/1820083005/ . Sorry!

[tkent, 2016-03-25 01:37:25]

Description was changed from

==========
Remove ASSERT_ARG().

ASSERT_ARG() is not much helpful than normal ASSERT() and DCHECK(). So this CL
removes it, and replaces existing call sites with DCHECK().

Also, this CL moves Node stream printers from testing code to production code
because they are used in DCHECK().

BUG=596760

Committed: https://crrev.com/25e8e9a87ba795375862c9a33ae3d9704eebe489
Cr-Commit-Position: refs/heads/master@{#383047}
==========

to

==========
Remove ASSERT_ARG().

ASSERT_ARG() is not much helpful than normal ASSERT() and DCHECK(). So this CL
removes it, and replaces existing call sites with DCHECK().

Also, this CL moves Node stream printers from testing code to production code
because they are used in DCHECK().

This relands crrev.com/383047 with just rebase.

BUG=596760
==========

[tkent, 2016-03-25 01:37:32]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-03-25 01:37:33]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/1828163002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-03-25 01:37:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1828163002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1828163002/40001

[commit-bot: I haz the power, 2016-03-25 03:17:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-25 03:19:35]

Description was changed from

==========
Remove ASSERT_ARG().

ASSERT_ARG() is not much helpful than normal ASSERT() and DCHECK(). So this CL
removes it, and replaces existing call sites with DCHECK().

Also, this CL moves Node stream printers from testing code to production code
because they are used in DCHECK().

This relands crrev.com/383047 with just rebase.

BUG=596760
==========

to

==========
Remove ASSERT_ARG().

ASSERT_ARG() is not much helpful than normal ASSERT() and DCHECK(). So this CL
removes it, and replaces existing call sites with DCHECK().

Also, this CL moves Node stream printers from testing code to production code
because they are used in DCHECK().

This relands crrev.com/383047 with just rebase.

BUG=596760

Committed: https://crrev.com/ec47b3501ce1e462c5721a870c9aabd0ef3581ab
Cr-Commit-Position: refs/heads/master@{#383236}
==========

[commit-bot: I haz the power, 2016-03-25 03:19:36]

Patchset 3 (id:??) landed as
https://crrev.com/ec47b3501ce1e462c5721a870c9aabd0ef3581ab
Cr-Commit-Position: refs/heads/master@{#383236}