third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp - Issue 1828163002: Remove ASSERT_ARG().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

Issue 1828163002: Remove ASSERT_ARG(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp b/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

index 82832742f97dde4e3be647c5154a6a049139a0d4..2eef701ea6bdaeddc75be749f2fe783ea01eb9da 100644

--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

@@ -192,8 +192,8 @@ CSSPrimitiveValue::UnitType CSSPrimitiveValue::typeWithCalcResolved() const

static const AtomicString& valueName(CSSValueID valueID)

{

- ASSERT_ARG(valueID, valueID >= 0);

- ASSERT_ARG(valueID, valueID < numCSSValueKeywords);

+ DCHECK_GE(valueID, 0);

+ DCHECK_LT(valueID, numCSSValueKeywords);

if (valueID < 0)

return nullAtom;