Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/web/ios_web_shell.gyp

Issue 1828143007: Web shell integration test suite. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't strip away globals Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ios/third_party/ochamcrest/ochamcrest.gyp ('K') | « ios/web/DEPS ('k') | ios/web/ios_web_shell_exported_symbols_list » ('j') | ios/web/ios_web_shell_tests.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/ios_web_shell.gyp
diff --git a/ios/web/ios_web_shell.gyp b/ios/web/ios_web_shell.gyp
index 9659780e3daf149931d775e6a95ca1d9b09f7ddf..1a66bfa30485d0c97b8872217914b6127ff5ea27 100644
--- a/ios/web/ios_web_shell.gyp
+++ b/ios/web/ios_web_shell.gyp
@@ -20,8 +20,10 @@
],
'xcode_settings': {
'INFOPLIST_FILE': 'shell/Info.plist',
+ 'STRIPFLAGS': '-S',
'OTHER_LDFLAGS': [
- '-Xlinker -objc_abi_version -Xlinker 2'
+ '-Xlinker -objc_abi_version -Xlinker 2 -exported_symbols_list',
sdefresne 2016/03/25 21:26:16 nit: can this be set as 'OTHER_LDFLAGS': [ '-Xl
justincohen 2016/03/25 22:51:21 Done.
+ '../../ios/web/ios_web_shell_exported_symbols_list'
sdefresne 2016/03/25 21:26:16 Is this file an input? I should be marked as so, s
]
},
'sources': [
@@ -68,6 +70,9 @@
'shell/view_controller.h',
'shell/view_controller.mm',
],
+ 'xcode_settings': {
+ 'GCC_SYMBOLS_PRIVATE_EXTERN': 'NO',
sdefresne 2016/03/25 21:26:16 Please comment.
+ },
'link_settings': {
'libraries': [
'$(SDKROOT)/System/Library/Frameworks/CoreGraphics.framework',
« ios/third_party/ochamcrest/ochamcrest.gyp ('K') | « ios/web/DEPS ('k') | ios/web/ios_web_shell_exported_symbols_list » ('j') | ios/web/ios_web_shell_tests.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698