Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1827913002: Remove support for DEPRECATED_java_in_dir (Closed)

Created:
4 years, 9 months ago by agrieve
Modified:
4 years, 9 months ago
Reviewers:
pkotwicz, Yaron
CC:
chromium-reviews, cjhopman
Base URL:
https://chromium.googlesource.com/chromium/src.git@java_in_dir
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove support for DEPRECATED_java_in_dir BUG=484854 Committed: https://crrev.com/5cb6ce43b7cb7d64d170d91a165910563537d10c Cr-Commit-Position: refs/heads/master@{#383002}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -42 lines) Patch
M build/config/android/internal_rules.gni View 2 chunks +2 lines, -23 lines 0 comments Download
M build/config/android/rules.gni View 6 chunks +2 lines, -19 lines 0 comments Download

Depends on Patchset:

Issue 1829823002 Patch 1

Messages

Total messages: 12 (6 generated)
agrieve
On 2016/03/23 18:28:35, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:pkotwicz@chromium.org 🌕
4 years, 9 months ago (2016-03-23 18:28:49 UTC) #3
pkotwicz
LGTM
4 years, 9 months ago (2016-03-24 00:15:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827913002/1
4 years, 9 months ago (2016-03-24 00:17:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-24 01:16:40 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5cb6ce43b7cb7d64d170d91a165910563537d10c Cr-Commit-Position: refs/heads/master@{#383002}
4 years, 9 months ago (2016-03-24 01:18:06 UTC) #10
Yaron
4 years, 9 months ago (2016-03-24 01:36:58 UTC) #12
Message was sent while issue was closed. 
:)

I'm sure cjhopman@ would be happy to see this if he checks chromium

Powered by Google App Engine
This is Rietveld 408576698