Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1827873002:
[Interpreter] Add OperandSize to code logging events for bytecode handlers. (Closed)
|
Created:
4 years, 9 months ago by Stefano Sanfilippo Modified:
4 years, 9 months ago CC:
v8-reviews_googlegroups.com, oth Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[Interpreter] Add OperandSize to code logging events for bytecode handlers.
BUG=v8:4280
LOG=N
Committed: https://crrev.com/529c0328070888fba87a39f7ad6eb0ac0d814e68
Cr-Commit-Position: refs/heads/master@{#35055}
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 22 (14 generated)
ssanfilippo@chromium.org changed reviewers: + oth@chromium.org, rmcilroy@chromium.org
Code logging events for bytecode handlers do not take OperandSize into account. Here's a small patch to fix it. PTAL.
LGTM, thanks.
The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827873002/1
The CQ bit was unchecked by ssanfilippo@chromium.org
The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827873002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [Interpreter] Code logging events for different handler operand sizes. BUG=v8:4280 LOG=N ========== to ========== [Interpreter] Fix code logging events for scalable handlers. BUG=v8:4280 LOG=N ==========
Description was changed from ========== [Interpreter] Fix code logging events for scalable handlers. BUG=v8:4280 LOG=N ========== to ========== [Interpreter] Fix code logging events for bytecode handlers. BUG=v8:4280 LOG=N ==========
Description was changed from ========== [Interpreter] Fix code logging events for bytecode handlers. BUG=v8:4280 LOG=N ========== to ========== [Interpreter] Fix bytecode handlers code logging events. BUG=v8:4280 LOG=N ==========
Description was changed from ========== [Interpreter] Fix bytecode handlers code logging events. BUG=v8:4280 LOG=N ========== to ========== [Interpreter] OperandSize in bytecode handlers code logging events. BUG=v8:4280 LOG=N ==========
Description was changed from ========== [Interpreter] OperandSize in bytecode handlers code logging events. BUG=v8:4280 LOG=N ========== to ========== [Interpreter] OperandSize in code logging events for bytecode handlers. BUG=v8:4280 LOG=N ==========
Description was changed from ========== [Interpreter] OperandSize in code logging events for bytecode handlers. BUG=v8:4280 LOG=N ========== to ========== [Interpreter] Add OperandSize to code logging events for bytecode handlers. BUG=v8:4280 LOG=N ==========
The CQ bit was checked by ssanfilippo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827873002/1
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Add OperandSize to code logging events for bytecode handlers. BUG=v8:4280 LOG=N ========== to ========== [Interpreter] Add OperandSize to code logging events for bytecode handlers. BUG=v8:4280 LOG=N ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Add OperandSize to code logging events for bytecode handlers. BUG=v8:4280 LOG=N ========== to ========== [Interpreter] Add OperandSize to code logging events for bytecode handlers. BUG=v8:4280 LOG=N Committed: https://crrev.com/529c0328070888fba87a39f7ad6eb0ac0d814e68 Cr-Commit-Position: refs/heads/master@{#35055} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/529c0328070888fba87a39f7ad6eb0ac0d814e68 Cr-Commit-Position: refs/heads/master@{#35055} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
