Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1830593002: [Interpreter] Move BytecodeHasHandler() from Interpreter to Bytecodes. (Closed)

Created:
4 years, 9 months ago by Stefano Sanfilippo
Modified:
4 years, 8 months ago
Reviewers:
oth
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@fix-codelog
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Move BytecodeHasHandler() from Interpreter to Bytecodes. BUG=v8:4280 LOG=N Committed: https://crrev.com/ce033d56dd67aba0502410f6bad766dfe699b552 Cr-Commit-Position: refs/heads/master@{#35254}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase, remove leftover declaration in interpreter.h. #

Patch Set 3 : Expand function doc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -15 lines) Patch
M src/interpreter/bytecodes.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M src/interpreter/bytecodes.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M src/interpreter/interpreter.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 3 chunks +2 lines, -9 lines 0 comments Download
M src/log.cc View 1 chunk +1 line, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (6 generated)
Stefano Sanfilippo
4 years, 9 months ago (2016-03-24 15:42:52 UTC) #2
oth
lgtm, one minor comment. https://codereview.chromium.org/1830593002/diff/1/src/interpreter/bytecodes.h File src/interpreter/bytecodes.h (right): https://codereview.chromium.org/1830593002/diff/1/src/interpreter/bytecodes.h#newcode515 src/interpreter/bytecodes.h:515: // Returns true if a ...
4 years, 9 months ago (2016-03-24 15:50:35 UTC) #3
Stefano Sanfilippo
https://codereview.chromium.org/1830593002/diff/1/src/interpreter/bytecodes.h File src/interpreter/bytecodes.h (right): https://codereview.chromium.org/1830593002/diff/1/src/interpreter/bytecodes.h#newcode515 src/interpreter/bytecodes.h:515: // Returns true if a handler is generated for ...
4 years, 9 months ago (2016-03-24 16:07:15 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830593002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830593002/40001
4 years, 9 months ago (2016-03-24 16:17:05 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-24 17:12:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830593002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830593002/40001
4 years, 8 months ago (2016-04-05 09:42:28 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-05 10:05:40 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 10:06:31 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ce033d56dd67aba0502410f6bad766dfe699b552
Cr-Commit-Position: refs/heads/master@{#35254}

Powered by Google App Engine
This is Rietveld 408576698