Move the run() method in Manager, and make the needs_servers method private.

Move the run() method in Manager, and make the needs_servers method private.

This is an optional minor refactoring.

Reason: Putting the main public method first after the constructor, rather than in the middle, seems to be a more natural ordering.

The rest of the methods in this class are helper methods not used outside
of this class, and thus should all be private, including needs_servers.

Committed: https://crrev.com/ebb7010a0f797f1dc2f95fffca2904013eed90de
Cr-Commit-Position: refs/heads/master@{#383859}

[qyearsley, 2016-03-29 21:12:34]

Description was changed from

==========
Move the run() method in Manager, and make the needs_servers method private.

When reading through this module, I felt that putting run() method first
after the constructor rather than in the middle was a more intuitive ordering.

The rest of the methods in this class are helper methods not used outside
of this class (and thus should all be private).
==========

to

==========
Move the run() method in Manager, and make the needs_servers method private.

This is an optional minor refactoring.

Reason: Putting the main public method first after the constructor, rather than
in the middle, seems to be a more natural ordering.

The rest of the methods in this class are helper methods not used outside
of this class, and thus should all be private, including needs_servers.
==========

[qyearsley, 2016-03-29 21:12:34]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-03-29 21:28:57]

lgtm, though I'm a bit surprised that pylint doesn't complain about calling
_needs_headers() from the test file?

[qyearsley, 2016-03-29 22:05:50]

On 2016/03/29 at 21:28:57, dpranke wrote:
> lgtm, though I'm a bit surprised that pylint doesn't complain about calling
_needs_headers() from the test file?

I just checked why this is, and it is because W0212 (protected-access) is
disabled in webkitpy/pylintrc.

Also, webkit.style.checkers.python.PythonChecker._run_pylint runs pylint with
--errors-only, and protected-access is just considered a warning, so it wouldn't
be printed anyway, either by check-webkit-style or by lint-webkitpy.

For this CL, I think it's fine to let manager_unittest call private methods of
manager, but later it would be nice to enable this check.

[qyearsley, 2016-03-29 22:05:53]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-03-29 22:06:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1827833005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1827833005/1

[commit-bot: I haz the power, 2016-03-29 23:23:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-29 23:24:36]

Description was changed from

==========
Move the run() method in Manager, and make the needs_servers method private.

This is an optional minor refactoring.

Reason: Putting the main public method first after the constructor, rather than
in the middle, seems to be a more natural ordering.

The rest of the methods in this class are helper methods not used outside
of this class, and thus should all be private, including needs_servers.
==========

to

==========
Move the run() method in Manager, and make the needs_servers method private.

This is an optional minor refactoring.

Reason: Putting the main public method first after the constructor, rather than
in the middle, seems to be a more natural ordering.

The rest of the methods in this class are helper methods not used outside
of this class, and thus should all be private, including needs_servers.

Committed: https://crrev.com/ebb7010a0f797f1dc2f95fffca2904013eed90de
Cr-Commit-Position: refs/heads/master@{#383859}
==========

[commit-bot: I haz the power, 2016-03-29 23:24:37]

Patchset 1 (id:??) landed as
https://crrev.com/ebb7010a0f797f1dc2f95fffca2904013eed90de
Cr-Commit-Position: refs/heads/master@{#383859}