third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py - Issue 1827833005: Move the run() method in Manager, and make the needs_servers method private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py

Issue 1827833005: Move the run() method in Manager, and make the needs_servers method private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py

index 2247b67e3c10fb54316a51ac01e75cb66d291dc3..f7cd91911fd7a3e91a1e3b9e21fdeff862e29e88 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py

@@ -56,10 +56,10 @@ class ManagerTest(unittest.TestCase):

return manager

manager = get_manager()

- self.assertFalse(manager.needs_servers(['fast/html']))

+ self.assertFalse(manager._needs_servers(['fast/html']))

manager = get_manager()

- self.assertTrue(manager.needs_servers(['http/tests/misc']))

+ self.assertTrue(manager._needs_servers(['http/tests/misc']))

def test_servers_started(self):

def get_manager(port):

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py ('k') | no next file » | no next file with comments »