MD Settings: Rename and fix confusing prefs test function

MD Settings: Rename and fix confusing prefs test function

The misleading "resetForTesting" actually just partially
uninitialized the element, making it behave unexpectedly in
tests. The function has been expanded into
"uninitializeForTesting" which correctly un-initializes
the element.

See also https://codereview.chromium.org/1833613002#ps1 for more
fallout from this confusion.

[michaelpg, 2016-03-24 03:30:18]

Description was changed from

==========
MD Settings: Rename confusing prefs test function

My own function was confusing me into breaking tests
==========

to

==========
MD Settings: Rename confusing prefs test function

The misleading "resetForTesting" actually just partially
uninitialized the element, making it behave unexpectedly in
tests. The function has been expanded into
"uninitializeForTesting" which correctly un-initializes it,
and "reinitializeForTesting" which correctly re-initializes it.

See also https://codereview.chromium.org/1833613002#ps1 for more
fallout from this confusion.
==========

[michaelpg, 2016-03-24 03:30:19]

michaelpg@chromium.org changed reviewers:
+ dbeam@chromium.org

[michaelpg, 2016-03-24 03:30:59]

Description was changed from

==========
MD Settings: Rename confusing prefs test function

The misleading "resetForTesting" actually just partially
uninitialized the element, making it behave unexpectedly in
tests. The function has been expanded into
"uninitializeForTesting" which correctly un-initializes it,
and "reinitializeForTesting" which correctly re-initializes it.

See also https://codereview.chromium.org/1833613002#ps1 for more
fallout from this confusion.
==========

to

==========
MD Settings: Rename confusing prefs test function

The misleading "resetForTesting" actually just partially
uninitialized the element, making it behave unexpectedly in
tests. The function has been expanded into
"uninitializeForTesting" which correctly un-initializes it,
and "reinitializeForTesting" which correctly re-initializes it (and which I will
use in a CL in progress).

See also https://codereview.chromium.org/1833613002#ps1 for more
fallout from this confusion.
==========

[michaelpg, 2016-03-24 03:31:07]

Description was changed from

==========
MD Settings: Rename confusing prefs test function

The misleading "resetForTesting" actually just partially
uninitialized the element, making it behave unexpectedly in
tests. The function has been expanded into
"uninitializeForTesting" which correctly un-initializes it,
and "reinitializeForTesting" which correctly re-initializes it (and which I will
use in a CL in progress).

See also https://codereview.chromium.org/1833613002#ps1 for more
fallout from this confusion.
==========

to

==========
MD Settings: Rename confusing prefs test function

The misleading "resetForTesting" actually just partially
uninitialized the element, making it behave unexpectedly in
tests. The function has been expanded into
"uninitializeForTesting" which correctly un-initializes it,
and "reinitializeForTesting" which correctly re-initializes it
(and which I will use in a CL in progress).

See also https://codereview.chromium.org/1833613002#ps1 for more
fallout from this confusion.
==========

[michaelpg, 2016-03-24 04:04:58]

Description was changed from

==========
MD Settings: Rename confusing prefs test function

The misleading "resetForTesting" actually just partially
uninitialized the element, making it behave unexpectedly in
tests. The function has been expanded into
"uninitializeForTesting" which correctly un-initializes it,
and "reinitializeForTesting" which correctly re-initializes it
(and which I will use in a CL in progress).

See also https://codereview.chromium.org/1833613002#ps1 for more
fallout from this confusion.
==========

to

==========
MD Settings: Rename and fix confusing prefs test function

The misleading "resetForTesting" actually just partially
uninitialized the element, making it behave unexpectedly in
tests. The function has been expanded into
"uninitializeForTesting" which correctly un-initializes
the element.

See also https://codereview.chromium.org/1833613002#ps1 for more
fallout from this confusion.
==========

[michaelpg, 2016-03-24 04:05:41]

simplified

[Dan Beam, 2016-03-24 19:08:42]

i don't think this is actually clearer