Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: chrome/browser/resources/settings/prefs/prefs.js

Issue 1827823003: MD Settings: Rename and fix confusing prefs test function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@PrefsTests
Patch Set: simplify Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/prefs_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/prefs/prefs.js
diff --git a/chrome/browser/resources/settings/prefs/prefs.js b/chrome/browser/resources/settings/prefs/prefs.js
index e466e58391bf046186bd5b726bc9ace43665d59b..c17dbcb5462f46e8eafcaa6f0115c9242d80bca0 100644
--- a/chrome/browser/resources/settings/prefs/prefs.js
+++ b/chrome/browser/resources/settings/prefs/prefs.js
@@ -238,11 +238,12 @@
},
/**
- * Uninitializes this element to remove it from tests. Also resets
+ * Uninitializes this element to render it inert in tests. Also resets
* settings-prefs-singleton, allowing newly created elements to
* re-initialize it.
*/
- resetForTesting: function() {
+ uninitializeForTesting: function() {
+ this.stopListening_();
this.singleton_.resetForTesting();
},
});
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/prefs_tests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698