Speculative attempt to unflake preload iframe test

Speculative attempt to unflake preload iframe test

https://codereview.chromium.org/1738133002 landed an iframe test for preload,
which seems to be slightly flaky. This is an attempt to unflake the test
by increasing its timeout.

BUG=597097
Committed: https://crrev.com/69e8ba23ef353ca5a06d2d9acd9da50ace03da28
Cr-Commit-Position: refs/heads/master@{#383077}

[Yoav Weiss, 2016-03-23 13:50:46]

yoav@yoav.ws changed reviewers:
+ creis@chromium.org

[Yoav Weiss, 2016-03-23 13:50:47]

Hey Charlie,

Can you take a look at this attempt to unflake?

Thanks!

[Yoav Weiss, 2016-03-23 16:04:47]

Description was changed from

==========
Speculative attempt to unflake preload iframe test

https://codereview.chromium.org/1738133002 landed an iframe test for preload,
which seems to be slightly flaky. This is an attempt to unflake the test
by increasing its timeout.

BUG=
==========

to

==========
Speculative attempt to unflake preload iframe test

https://codereview.chromium.org/1738133002 landed an iframe test for preload,
which seems to be slightly flaky. This is an attempt to unflake the test
by increasing its timeout.

BUG=597097
==========

[Charlie Reis, 2016-03-23 16:49:53]

creis@chromium.org changed reviewers:
+ japhet@chromium.org

[Charlie Reis, 2016-03-23 16:49:53]

Hmm, that's not an effective strategy for avoiding flakiness.  The bots are
frequently overloaded and just increasing the timeout probably won't help much.

I haven't worked on layout tests in a long time, though.  Nate, can you
recommend any ways to make this test less flaky?

[Nate Chapin, 2016-03-23 17:17:41]

https://codereview.chromium.org/1827773002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/linkHeader/resources/iframe-link-headers.php
(right):

https://codereview.chromium.org/1827773002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/linkHeader/resources/iframe-link-headers.php:11:
if (entries[i].name.indexOf("square") != -1)
Is the goal here to just ensure that the Link header triggered a preload, and
performance is just a way to observe the resource load? If so, you should be
able to reliably check this in a layout test with
window.internals.isPreloaded(url), and that shouldn't require the preload to
finish in order to observe it.

[Yoav Weiss, 2016-03-24 10:45:40]

On 2016/03/23 17:17:41, Nate Chapin wrote:
>
https://codereview.chromium.org/1827773002/diff/1/third_party/WebKit/LayoutTe...
> File
>
third_party/WebKit/LayoutTests/http/tests/linkHeader/resources/iframe-link-headers.php
> (right):
> 
>
https://codereview.chromium.org/1827773002/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/http/tests/linkHeader/resources/iframe-link-headers.php:11:
> if (entries[i].name.indexOf("square") != -1)
> Is the goal here to just ensure that the Link header triggered a preload, and
> performance is just a way to observe the resource load? If so, you should be
> able to reliably check this in a layout test with
> window.internals.isPreloaded(url), and that shouldn't require the preload to
> finish in order to observe it.

Yeah, that would work better without a timeout

[Nate Chapin, 2016-03-24 16:34:24]

lgtm

[Charlie Reis, 2016-03-24 16:35:01]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2016-03-24 16:35:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1827773002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1827773002/20001

[commit-bot: I haz the power, 2016-03-24 16:43:16]

Description was changed from

==========
Speculative attempt to unflake preload iframe test

https://codereview.chromium.org/1738133002 landed an iframe test for preload,
which seems to be slightly flaky. This is an attempt to unflake the test
by increasing its timeout.

BUG=597097
==========

to

==========
Speculative attempt to unflake preload iframe test

https://codereview.chromium.org/1738133002 landed an iframe test for preload,
which seems to be slightly flaky. This is an attempt to unflake the test
by increasing its timeout.

BUG=597097
==========

[commit-bot: I haz the power, 2016-03-24 16:43:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-24 16:44:53]

Description was changed from

==========
Speculative attempt to unflake preload iframe test

https://codereview.chromium.org/1738133002 landed an iframe test for preload,
which seems to be slightly flaky. This is an attempt to unflake the test
by increasing its timeout.

BUG=597097
==========

to

==========
Speculative attempt to unflake preload iframe test

https://codereview.chromium.org/1738133002 landed an iframe test for preload,
which seems to be slightly flaky. This is an attempt to unflake the test
by increasing its timeout.

BUG=597097

Committed: https://crrev.com/69e8ba23ef353ca5a06d2d9acd9da50ace03da28
Cr-Commit-Position: refs/heads/master@{#383077}
==========

[commit-bot: I haz the power, 2016-03-24 16:44:54]

Patchset 2 (id:??) landed as
https://crrev.com/69e8ba23ef353ca5a06d2d9acd9da50ace03da28
Cr-Commit-Position: refs/heads/master@{#383077}