third_party/WebKit/LayoutTests/http/tests/linkHeader/resources/iframe-link-headers.php - Issue 1827773002: Speculative attempt to unflake preload iframe test

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/linkHeader/resources/iframe-link-headers.php

Issue 1827773002: Speculative attempt to unflake preload iframe test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <?php	1 <?php

2 header("Link: <http://127.0.0.1:8000/resources/square.png>;rel=preload;as=im age;", false);	2 header("Link: <http://127.0.0.1:8000/resources/square.png>;rel=preload;as=im age;", false);

3 ?>	3 ?>

4 <!DOCTYPE html>	4 <!DOCTYPE html>

5 <script>	5 <script>

6 window.addEventListener("load", function() {	6 window.addEventListener("load", function() {

7 var entries = performance.getEntriesByType("resource");	7 var entries = performance.getEntriesByType("resource");

8 var smallLoaded = false;	8 var smallLoaded = false;

9 for (var i = 0; i < entries.length; ++i) {	9 for (var i = 0; i < entries.length; ++i) {

10 top.console.log(entries[i].name);	10 top.console.log(entries[i].name);

11 if (entries[i].name.indexOf("square") != -1)	11 if (entries[i].name.indexOf("square") != -1)
	Nate Chapin 2016/03/23 17:17:41 Is the goal here to just ensure that the Link head Is the goal here to just ensure that the Link header triggered a preload, and performance is just a way to observe the resource load? If so, you should be able to reliably check this in a layout test with window.internals.isPreloaded(url), and that shouldn't require the preload to finish in order to observe it.
12 top.postMessage("squareloaded", "*");	12 top.postMessage("squareloaded", "*");

13 }	13 }

14 top.postMessage("notloaded", "*");	14 top.postMessage("notloaded", "*");

15 });	15 });

16 </script>	16 </script>

17 <script src="../resources/slow-script.pl?delay=200"></script>	17 <script src="../resources/slow-script.pl?delay=400"></script>

18	18

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »