Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 18277005: MIPS: Generate StoreGlobal stubs with Hydrogen. (Closed)

Created:
7 years, 5 months ago by kilvadyb
Modified:
7 years, 5 months ago
Reviewers:
kisg, Paul Lind, palfia, danno
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

MIPS: Generate StoreGlobal stubs with Hydrogen. Port r15512 (bdf9918) Original commit message: - Constants globals are inlined into Hydrogen code using code dependencies that invalidate the Crankshafted code when global PropertyCells or the global object change. - The more general case generates code that is just as good as the hand-written assembly stubs on all platforms. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M src/mips/code-stubs-mips.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/mips/lithium-gap-resolver-mips.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
kisg
lgtm
7 years, 5 months ago (2013-07-05 14:39:15 UTC) #1
palfia
7 years, 5 months ago (2013-07-05 14:52:16 UTC) #2
Committed as r15525.

Powered by Google App Engine
This is Rietveld 408576698