Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1827603002: Remove aura_bench (Closed)

Created:
4 years, 9 months ago by enne (OOO)
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke, sky, piman
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove aura_bench This isn't used anymore. R=piman@chromium.org BUG=597021 Committed: https://crrev.com/de5c26563c6707dba2ef5abb97104aebd9bd3d51 Cr-Commit-Position: refs/heads/master@{#383302}

Patch Set 1 #

Patch Set 2 : Remove toplevel aura:bench too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -464 lines) Patch
M BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M build/gn_migration.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/BUILD.gn View 1 chunk +0 lines, -31 lines 0 comments Download
M ui/aura/aura.gyp View 1 chunk +0 lines, -34 lines 0 comments Download
D ui/aura/bench/DEPS View 1 chunk +0 lines, -8 lines 0 comments Download
D ui/aura/bench/bench_main.cc View 1 chunk +0 lines, -389 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
enne (OOO)
4 years, 9 months ago (2016-03-22 23:00:22 UTC) #1
piman
lgtm
4 years, 9 months ago (2016-03-23 00:32:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827603002/20001
4 years, 9 months ago (2016-03-23 16:55:01 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/160099)
4 years, 9 months ago (2016-03-23 17:04:44 UTC) #6
enne (OOO)
+sky
4 years, 9 months ago (2016-03-24 17:21:52 UTC) #8
sky
LGTM
4 years, 9 months ago (2016-03-24 19:01:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827603002/20001
4 years, 9 months ago (2016-03-24 19:47:12 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/160552)
4 years, 9 months ago (2016-03-24 20:01:27 UTC) #13
enne (OOO)
+dpranke
4 years, 9 months ago (2016-03-24 20:55:17 UTC) #15
Dirk Pranke
lgtm.
4 years, 9 months ago (2016-03-24 21:30:30 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827603002/20001
4 years, 9 months ago (2016-03-25 17:54:57 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-25 18:04:03 UTC) #19
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 18:06:43 UTC) #21
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/de5c26563c6707dba2ef5abb97104aebd9bd3d51
Cr-Commit-Position: refs/heads/master@{#383302}

Powered by Google App Engine
This is Rietveld 408576698