Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1827563002: Improve tablet mode detection on Windows 10+ (Closed)

Created:
4 years, 9 months ago by ananta
Modified:
4 years, 9 months ago
Reviewers:
jschuh
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

Improve tablet mode detection on Windows 10+ Merging to M49 This patch introduces the following:- 1. A function IsWindows10TabletMode which uses the new WRL API's on Windows 10 to query the current interaction mode. As per msdn these API's can be called from Win32 apps. https://msdn.microsoft.com/en-us/library/windows/hardware/dn917883(v=vs.85).aspx https://software.intel.com/en-us/articles/detecting-slateclamshell-mode-screen-orientation-in-convertible-pc These API's however appear to always return UserModeTouch which indicates tablet mode on the Surface 4 configuration I was testing with. 2. If the IsTabletDevice function returns true we don't attempt to detect keyboards and just assume that there is no keyboard attached. BUG=497381 TBR=jschuh Review URL: https://codereview.chromium.org/1783123003 Cr-Commit-Position: refs/heads/master@{#380864} (cherry picked from commit d67aae27c1137d077f228d27cae2337d2b8caefa) Conflicts: base/win/win_util.cc Committed: https://chromium.googlesource.com/chromium/src/+/8097f2b954d27107590d082012c511619350b341

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -3 lines) Patch
M base/win/win_util.cc View 7 chunks +92 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
ananta
4 years, 9 months ago (2016-03-22 19:50:33 UTC) #3
ananta
4 years, 9 months ago (2016-03-22 19:59:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8097f2b954d27107590d082012c511619350b341 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698