Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1827413002: Fixes for Swarming recipes (Closed)

Created:
4 years, 9 months ago by borenet2
Modified:
4 years, 8 months ago
Reviewers:
borenet, rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : sdfklsdfalk #

Patch Set 3 : kitchen wrapper hack #

Patch Set 4 : ... #

Patch Set 5 : recipes.py #

Patch Set 6 : path #

Patch Set 7 : fix recipes.py path #

Patch Set 8 : fix path again #

Patch Set 9 : path again #

Patch Set 10 : no recipe name #

Patch Set 11 : ... #

Patch Set 12 : ... #

Patch Set 13 : Remove no longer needed files #

Patch Set 14 : remove command from isolates #

Patch Set 15 : Add VERSION files to isolates #

Patch Set 16 : Reinstate tmp_dir #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1681 lines) Patch
D infra/bots/add_isolated_input.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -33 lines 0 comments Download
M infra/bots/common.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +0 lines, -436 lines 1 comment Download
M infra/bots/compile_skia.isolate View 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -5 lines 0 comments Download
D infra/bots/compile_skia.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -27 lines 0 comments Download
D infra/bots/flavor/__init__.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -6 lines 0 comments Download
D infra/bots/flavor/android_devices.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -100 lines 0 comments Download
D infra/bots/flavor/android_flavor.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -241 lines 0 comments Download
D infra/bots/flavor/chromeos_flavor.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -59 lines 0 comments Download
D infra/bots/flavor/cmake_flavor.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -20 lines 0 comments Download
D infra/bots/flavor/coverage_flavor.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -114 lines 0 comments Download
D infra/bots/flavor/default_flavor.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -190 lines 0 comments Download
D infra/bots/flavor/ios_flavor.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -114 lines 0 comments Download
D infra/bots/flavor/ssh_devices.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -32 lines 0 comments Download
D infra/bots/flavor/ssh_flavor.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -123 lines 0 comments Download
D infra/bots/flavor/valgrind_flavor.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -31 lines 0 comments Download
D infra/bots/flavor/xsan_flavor.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -54 lines 0 comments Download
M infra/bots/images.isolate View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/perf_skia.isolate View 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -13 lines 0 comments Download
D infra/bots/perf_skia.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -35 lines 0 comments Download
M infra/bots/skps.isolate View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/test_skia.isolate View 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -13 lines 0 comments Download
D infra/bots/test_skia.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -35 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
borenet
Must land alongside https://codereview.chromium.org/1829423002/
4 years, 8 months ago (2016-03-30 14:01:01 UTC) #3
borenet
https://codereview.chromium.org/1827413002/diff/300001/infra/bots/common.py File infra/bots/common.py (right): https://codereview.chromium.org/1827413002/diff/300001/infra/bots/common.py#newcode1 infra/bots/common.py:1: #!/usr/bin/env python This file can be deleted entirely once ...
4 years, 8 months ago (2016-03-30 14:02:09 UTC) #4
rmistry
lgtm
4 years, 8 months ago (2016-03-30 14:11:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827413002/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827413002/300001
4 years, 8 months ago (2016-03-30 14:40:13 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 14:41:35 UTC) #10
Message was sent while issue was closed. 
Committed patchset #16 (id:300001) as
https://skia.googlesource.com/skia/+/15bc5603e44fdcac7418f08842974a80f935a577

Powered by Google App Engine
This is Rietveld 408576698